Merge lp:~robert-ancell/unity-control-center/lowercase-usernames into lp:unity-control-center

Proposed by Robert Ancell on 2016-07-11
Status: Merged
Approved by: Sebastien Bacher on 2016-07-13
Approved revision: 12867
Merged at revision: 12873
Proposed branch: lp:~robert-ancell/unity-control-center/lowercase-usernames
Merge into: lp:unity-control-center
Diff against target: 20 lines (+1/-2)
1 file modified
panels/user-accounts/um-utils.c (+1/-2)
To merge this branch: bzr merge lp:~robert-ancell/unity-control-center/lowercase-usernames
Reviewer Review Type Date Requested Status
Sebastien Bacher 2016-07-11 Approve on 2016-07-13
Review via email: mp+299635@code.launchpad.net

Commit message

Ubuntu only supports usernames with lowercase letters.

To post a comment you must log in.
Sebastien Bacher (seb128) wrote :

that makes sense

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'panels/user-accounts/um-utils.c'
2--- panels/user-accounts/um-utils.c 2014-04-04 13:44:16 +0000
3+++ panels/user-accounts/um-utils.c 2016-07-11 02:42:45 +0000
4@@ -520,7 +520,6 @@
5 */
6 for (c = username; *c; c++) {
7 if (! ((*c >= 'a' && *c <= 'z') ||
8- (*c >= 'A' && *c <= 'Z') ||
9 (*c >= '0' && *c <= '9') ||
10 (*c == '_') || (*c == '.') ||
11 (*c == '-' && c != username)))
12@@ -543,7 +542,7 @@
13 }
14 else {
15 *tip = g_strdup (_("The username must only consist of:\n"
16- " \xe2\x9e\xa3 letters from the English alphabet\n"
17+ " \xe2\x9e\xa3 lowercase letters from the English alphabet\n"
18 " \xe2\x9e\xa3 digits\n"
19 " \xe2\x9e\xa3 any of the characters '.', '-' and '_'"));
20 }

Subscribers

People subscribed via source and target branches