Merge lp:~robert-ancell/ubuntustudio-default-settings/lightdm-config-in-usr into lp:~ubuntustudio-dev/ubuntustudio-default-settings/devel

Proposed by Robert Ancell
Status: Merged
Approved by: Set Hallstrom
Approved revision: 260
Merged at revision: 284
Proposed branch: lp:~robert-ancell/ubuntustudio-default-settings/lightdm-config-in-usr
Merge into: lp:~ubuntustudio-dev/ubuntustudio-default-settings/devel
Diff against target: 33 lines (+9/-1)
3 files modified
debian/changelog (+7/-0)
debian/ubuntustudio-default-settings.maintscript (+1/-0)
usr/share/lightdm/lightdm.conf.d/60-ubuntustudio.conf (+1/-1)
To merge this branch: bzr merge lp:~robert-ancell/ubuntustudio-default-settings/lightdm-config-in-usr
Reviewer Review Type Date Requested Status
Set Hallstrom (community) assisted review Approve
Review via email: mp+233124@code.launchpad.net

Commit message

Move LightDM configuration from /etc/lightdm/lightdm.conf.d to
/usr/share/lightdm/lightdm.conf.d. Bump priority from 10 to 60.

Description of the change

Move LightDM configuration from /etc to /usr. This means it will be correctly removed if this package is uninstalled. Otherwise you can have invalid configuration (referring to a session that is not available).

This also stops people from editing this file (they should make their own snippet or edit /etc/lightdm/lightdm.conf if they want other changes).

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

You might also want to consider if the priority of this configuration is correct. Currently it will override the default Ubuntu configuration because config in /etc overrides config from /usr.

If you want to override the Ubuntu session we should change it to 60-ubuntustudio.conf.

259. By Robert Ancell

Change config priority from 10 to 60

260. By Robert Ancell

Use [Seat:*] section for LightDM configuration instead of deprecated [SeatDefaults]

Revision history for this message
Set Hallstrom (sakrecoer) wrote :

Hi Robert!
Sorry to get back to you so late. We have finally taken the steps to act upon your merge request. It seems one of the commits (260) got in there from somewhere else, so we adapted as well as we could for you to get the proper credits. Sorry if my terminology isn't the best here, I am learning bzr with the help of zequence and krytarik and this was a great merge exercise!
Thank you for taking the time to do this and sorry again for the delay.

Revision history for this message
Set Hallstrom (sakrecoer) wrote :

Reviewed the merge request with the help of krytarik

review: Approve (assisted review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-04-09 16:25:01 +0000
3+++ debian/changelog 2015-08-07 01:42:51 +0000
4@@ -1,3 +1,10 @@
5+ubuntustudio-default-settings (0.55) utopic; urgency=medium
6+
7+ * Move LightDM configuration from /etc/lightdm/lightdm.conf.d to
8+ /usr/share/lightdm/lightdm.conf.d
9+
10+ -- Robert Ancell <robert.ancell@canonical.com> Wed, 03 Sep 2014 09:05:41 +1200
11+
12 ubuntustudio-default-settings (0.54) trusty; urgency=medium
13
14 * Set default wallpaper key for gsettings based applications, e.g.
15
16=== modified file 'debian/ubuntustudio-default-settings.maintscript'
17--- debian/ubuntustudio-default-settings.maintscript 2013-10-22 18:39:29 +0000
18+++ debian/ubuntustudio-default-settings.maintscript 2015-08-07 01:42:51 +0000
19@@ -1,1 +1,2 @@
20 rm_conffile /etc/default/grub.d/50_ubuntustudio.cfg 0.50~
21+rm_conffile /etc/lightdm/lightdm.conf.d/10-ubuntustudio.conf 0.55~
22
23=== removed directory 'etc/lightdm'
24=== removed directory 'etc/lightdm/lightdm.conf.d'
25=== added directory 'usr/share/lightdm'
26=== added directory 'usr/share/lightdm/lightdm.conf.d'
27=== renamed file 'etc/lightdm/lightdm.conf.d/10-ubuntustudio.conf' => 'usr/share/lightdm/lightdm.conf.d/60-ubuntustudio.conf'
28--- etc/lightdm/lightdm.conf.d/10-ubuntustudio.conf 2014-01-09 13:40:33 +0000
29+++ usr/share/lightdm/lightdm.conf.d/60-ubuntustudio.conf 2015-08-07 01:42:51 +0000
30@@ -1,2 +1,2 @@
31-[SeatDefaults]
32+[Seat:*]
33 user-session=ubuntustudio

Subscribers

People subscribed via source and target branches