Merge lp:~robert-ancell/ubuntustudio-default-settings/lightdm-config-in-usr into lp:ubuntustudio-default-settings
| Status: | Merged |
|---|---|
| Approved by: | Set Hallstrom on 2016-03-19 |
| Approved revision: | 260 |
| Merged at revision: | 284 |
| Proposed branch: | lp:~robert-ancell/ubuntustudio-default-settings/lightdm-config-in-usr |
| Merge into: | lp:ubuntustudio-default-settings |
| Diff against target: |
33 lines (+9/-1) 3 files modified
debian/changelog (+7/-0) debian/ubuntustudio-default-settings.maintscript (+1/-0) usr/share/lightdm/lightdm.conf.d/60-ubuntustudio.conf (+1/-1) |
| To merge this branch: | bzr merge lp:~robert-ancell/ubuntustudio-default-settings/lightdm-config-in-usr |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Set Hallstrom | assisted review | 2014-09-02 | Approve on 2016-03-20 |
|
Review via email:
|
|||
Commit Message
Move LightDM configuration from /etc/lightdm/
/usr/share/
Description of the Change
Move LightDM configuration from /etc to /usr. This means it will be correctly removed if this package is uninstalled. Otherwise you can have invalid configuration (referring to a session that is not available).
This also stops people from editing this file (they should make their own snippet or edit /etc/lightdm/
| Robert Ancell (robert-ancell) wrote : | # |
- 259. By Robert Ancell on 2014-09-02
-
Change config priority from 10 to 60
- 260. By Robert Ancell on 2015-08-07
-
Use [Seat:*] section for LightDM configuration instead of deprecated [SeatDefaults]
| Set Hallstrom (sakrecoer) wrote : | # |
Hi Robert!
Sorry to get back to you so late. We have finally taken the steps to act upon your merge request. It seems one of the commits (260) got in there from somewhere else, so we adapted as well as we could for you to get the proper credits. Sorry if my terminology isn't the best here, I am learning bzr with the help of zequence and krytarik and this was a great merge exercise!
Thank you for taking the time to do this and sorry again for the delay.
| Set Hallstrom (sakrecoer) wrote : | # |
Reviewed the merge request with the help of krytarik

You might also want to consider if the priority of this configuration is correct. Currently it will override the default Ubuntu configuration because config in /etc overrides config from /usr.
If you want to override the Ubuntu session we should change it to 60-ubuntustudio .conf.