Mir

Merge lp:~robert-ancell/mir/vt-tty0 into lp:mir

Proposed by Robert Ancell on 2016-04-28
Status: Merged
Approved by: Alan Griffiths on 2016-04-28
Approved revision: 3483
Merged at revision: 3484
Proposed branch: lp:~robert-ancell/mir/vt-tty0
Merge into: lp:mir
Diff against target: 12 lines (+1/-1)
1 file modified
src/server/input/vt_filter.cpp (+1/-1)
To merge this branch: bzr merge lp:~robert-ancell/mir/vt-tty0
Reviewer Review Type Date Requested Status
Mir CI Bot continuous-integration Approve on 2016-04-28
Alan Griffiths Abstain on 2016-04-28
Cemil Azizoglu (community) 2016-04-28 Approve on 2016-04-28
Review via email: mp+293277@code.launchpad.net

Commit message

Use /dev/tty0 instead of /dev/console.

For some unknown reason /dev/console doesn't seem to be working in Ubuntu 16.04.
Use /dev/tty0 as that is what logind / LightDM / GDM are using.

To post a comment you must log in.
Cemil Azizoglu (cemil-azizoglu) wrote :

ok

review: Approve
Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:3483
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~robert-ancell/mir/vt-tty0/+merge/293277/+edit-commit-message

https://mir-jenkins.ubuntu.com/job/mir-ci/913/
Executed test runs:
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-mir/960
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/1002
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/993
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/993
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/970
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/970/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/970
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/970/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/970
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/970/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/970
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/970/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/970
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/970/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/913/rebuild

review: Needs Fixing (continuous-integration)
Alan Griffiths (alan-griffiths) wrote :

I don't have a problem with the change if it works for you, but VT switching is working on all the 16.04 machines I use. What is needed to make it fail?

review: Needs Information
Alan Griffiths (alan-griffiths) wrote :

> I don't have a problem with the change if it works for you, but VT switching
> is working on all the 16.04 machines I use. What is needed to make it fail?

I guess that's abstain.

review: Abstain
Robert Ancell (robert-ancell) wrote :

My guess it is video driver / hardware dependent, but I wasn't able to exactly pinpoint where the issue is. I couldn't find any documentation as to which device is the correct one to use, but /dev/tty0 seems to be used by larger projects (logind, GDM) and thus is probably better tested.

Mir CI Bot (mir-ci-bot) wrote :

FAILED: Continuous integration, rev:3483
https://mir-jenkins.ubuntu.com/job/mir-ci/918/
Executed test runs:
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-mir/966/console
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-0-fetch/1012
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1003
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1003
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/976
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=clang,platform=mesa,release=vivid+overlay/976/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/976
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=amd64,compiler=gcc,platform=mesa,release=xenial/976/artifact/output/*zip*/output.zip
    FAILURE: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/976/console
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=cross-armhf,compiler=gcc,platform=android,release=vivid+overlay/976/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/976
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=android,release=vivid+overlay/976/artifact/output/*zip*/output.zip
    SUCCESS: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/976
        deb: https://mir-jenkins.ubuntu.com/job/build-2-binpkg-mir/arch=i386,compiler=gcc,platform=mesa,release=xenial/976/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://mir-jenkins.ubuntu.com/job/mir-ci/918/rebuild

review: Needs Fixing (continuous-integration)
Mir CI Bot (mir-ci-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/server/input/vt_filter.cpp'
2--- src/server/input/vt_filter.cpp 2016-01-29 08:18:22 +0000
3+++ src/server/input/vt_filter.cpp 2016-04-28 14:41:08 +0000
4@@ -29,7 +29,7 @@
5 {
6 void set_active_vt(int vt)
7 {
8- auto console_fd = open("/dev/console", O_RDONLY | O_NDELAY);
9+ auto console_fd = open("/dev/tty0", O_RDONLY | O_NDELAY);
10 ioctl(console_fd, VT_ACTIVATE, vt);
11 close(console_fd);
12 }

Subscribers

People subscribed via source and target branches