Merge lp:~robert-ancell/lightdm/test-mode-broken into lp:lightdm

Proposed by Robert Ancell
Status: Merged
Approved by: Robert Ancell
Approved revision: 1791
Merged at revision: 1791
Proposed branch: lp:~robert-ancell/lightdm/test-mode-broken
Merge into: lp:lightdm
Diff against target: 46 lines (+14/-4)
2 files modified
src/seat.c (+12/-4)
src/session.c (+2/-0)
To merge this branch: bzr merge lp:~robert-ancell/lightdm/test-mode-broken
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Robert Ancell Approve
Review via email: mp+186560@code.launchpad.net

Commit message

Fix test-mode not working, don't try and run the greeter as the greeter user

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/seat.c'
2--- src/seat.c 2013-09-09 03:24:00 +0000
3+++ src/seat.c 2013-09-19 15:29:33 +0000
4@@ -1050,7 +1050,6 @@
5 gchar *sessions_dir, **argv;
6 SessionConfig *session_config;
7 Greeter *greeter_session;
8- gchar *greeter_user;
9 const gchar *greeter_wrapper;
10
11 l_debug (seat, "Creating greeter session");
12@@ -1081,9 +1080,18 @@
13 set_session_env (SESSION (greeter_session));
14
15 session_set_pam_service (SESSION (greeter_session), GREETER_SERVICE);
16- greeter_user = config_get_string (config_get_instance (), "LightDM", "greeter-user");
17- session_set_username (SESSION (greeter_session), greeter_user);
18- g_free (greeter_user);
19+ if (getuid () == 0)
20+ {
21+ gchar *greeter_user;
22+ greeter_user = config_get_string (config_get_instance (), "LightDM", "greeter-user");
23+ session_set_username (SESSION (greeter_session), greeter_user);
24+ g_free (greeter_user);
25+ }
26+ else
27+ {
28+ /* In test mode run the greeter as ourself */
29+ session_set_username (SESSION (greeter_session), user_get_name (accounts_get_current_user ()));
30+ }
31 session_set_argv (SESSION (greeter_session), argv);
32 g_strfreev (argv);
33
34
35=== modified file 'src/session.c'
36--- src/session.c 2013-08-24 05:28:19 +0000
37+++ src/session.c 2013-09-19 15:29:33 +0000
38@@ -758,6 +758,8 @@
39 else
40 x_authority_filename = g_build_filename (user_get_home_directory (session_get_user (session)), ".Xauthority", NULL);
41
42+ if (session->priv->log_filename)
43+ l_debug (session, "Logging to %s", session->priv->log_filename);
44 write_string (session, session->priv->log_filename);
45 write_string (session, session->priv->tty);
46 write_string (session, x_authority_filename);

Subscribers

People subscribed via source and target branches