Merge lp:~robert-ancell/lightdm/guest-wrapper into lp:lightdm

[Robert Ancell]

Implement missing guest-wrapper functionality and enable it for Ubuntu. Update AppArmor scripts to work.

[Robert Ancell (robert-ancell)]

Remote sessions need to be tested with this before it can land. Guest sessions work fine.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1831
http://jenkins.qa.ubuntu.com/job/lightdm-ci/211/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/lightdm-trusty-amd64-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/lightdm-trusty-armhf-ci/5

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/lightdm-ci/211/rebuild

review: Approve (continuous-integration)

[lp:~robert-ancell/lightdm/guest-wrapper]

1832. By Robert Ancell on 2013-10-30

Merge with trunk

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:1832
http://jenkins.qa.ubuntu.com/job/lightdm-ci/212/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/lightdm-trusty-amd64-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/lightdm-trusty-armhf-ci/6

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/lightdm-ci/212/rebuild

review: Approve (continuous-integration)

[Robert Ancell (robert-ancell)]

Approving for trunk without remote session testing being completed.

review: Approve

=== modified file 'data/apparmor/abstractions/lightdm'
--- data/apparmor/abstractions/lightdm	2013-06-13 00:14:02 +0000
+++ data/apparmor/abstractions/lightdm	2013-10-30 20:19:38 +0000
@@ -8,6 +8,10 @@
 # etc). Note that this profile intentionally omits chromium-browser.
 
   #include <abstractions/authentication>
+  #include <abstractions/cups-client>
+  #include <abstractions/dbus>
+  #include <abstractions/dbus-session>
+  #include <abstractions/dbus-accessibility>
   #include <abstractions/nameservice>
   #include <abstractions/wutmp>
   /etc/compizconfig/config rw, # bug in compiz https://launchpad.net/bugs/697678
@@ -47,6 +51,8 @@
   /sbin/** rmixk,
   /sys/ r,
   /sys/** rm,
+  # needed for confined trusted helpers, such as dbus-daemon
+  /sys/kernel/security/apparmor/.access rw,
   /tmp/ rw,
   owner /tmp/** rwlkmix,
   /usr/ r,

=== modified file 'data/lightdm.conf'
--- data/lightdm.conf	2013-10-29 08:26:48 +0000
+++ data/lightdm.conf	2013-10-30 20:19:38 +0000
@@ -14,7 +14,6 @@
 # sessions-directory = Directory to find sessions
 # remote-sessions-directory = Directory to find remote sessions
 # greeters-directory = Directory to find greeters
-# disable-guest-wrapper = Disable using guest session wrapper (temporary? required to make tests work without installing)
 #
 [LightDM]
 #start-default-seat=true
@@ -30,7 +29,6 @@
 #sessions-directory=/usr/share/lightdm/sessions:/usr/share/xsessions
 #remote-sessions-directory=/usr/share/lightdm/remote-sessions
 #greeters-directory=/usr/share/lightdm/greeters:/usr/share/xgreeters
-#disable-guest-wrapper=false
 
 #
 # Seat defaults
@@ -59,6 +57,7 @@
 # guest-session = Session to load for guests (overrides user-session)
 # session-wrapper = Wrapper script to run session with
 # greeter-wrapper = Wrapper script to run greeter with
+# guest-wrapper = Wrapper script to run guest sessions with
 # display-setup-script = Script to run when starting a greeter session (runs as root)
 # display-stopped-script = Script to run after stopping the display server (runs as root)
 # greeter-setup-script = Script to run when starting a greeter (runs as root)
@@ -96,6 +95,7 @@
 #guest-session=UNIMPLEMENTED
 #session-wrapper=lightdm-session
 #greeter-wrapper=
+#guest-wrapper=
 #display-setup-script=
 #display-stopped-script=
 #greeter-setup-script=

=== added file 'debian/50-guest-wrapper.conf'
--- debian/50-guest-wrapper.conf	1970-01-01 00:00:00 +0000
+++ debian/50-guest-wrapper.conf	2013-10-30 20:19:38 +0000
@@ -0,0 +1,2 @@
+[SeatDefaults]
+guest-wrapper=/usr/lib/lightdm/lightdm/lightdm-guest-session-wrapper

=== modified file 'debian/changelog'
--- debian/changelog	2013-10-21 23:20:25 +0000
+++ debian/changelog	2013-10-30 20:19:38 +0000
@@ -1,3 +1,10 @@
+lightdm (1.9.0-0ubuntu2) UNRELEASED; urgency=low
+
+  * debian/50-guest-wrapper.conf:
+    - Configure guest session wrapper to use
+
+ -- Robert Ancell <[e-mail]>  Sun, 27 Oct 2013 17:34:20 +1300
+
 lightdm (1.9.0-0ubuntu1) trusty; urgency=low
 
   * New upstream release:

=== modified file 'debian/lightdm.install'
--- debian/lightdm.install	2013-07-16 23:36:16 +0000
+++ debian/lightdm.install	2013-10-30 20:19:38 +0000
@@ -14,3 +14,4 @@
 debian/source_lightdm.py usr/share/apport/package-hooks
 debian/50-xserver-command.conf etc/lightdm/lightdm.conf.d
 debian/50-greeter-wrapper.conf etc/lightdm/lightdm.conf.d
+debian/50-guest-wrapper.conf etc/lightdm/lightdm.conf.d

=== modified file 'src/seat.c'
--- src/seat.c	2013-10-30 18:56:48 +0000
+++ src/seat.c	2013-10-30 20:19:38 +0000
@@ -880,10 +880,27 @@
     return session;
 }
 
+static void
+prepend_argv (gchar ***argv, const gchar *value)
+{
+    gchar **old_argv, **new_argv;
+    gint i;
+
+    old_argv = *argv;
+    new_argv = g_malloc (sizeof (gchar *) * (g_strv_length (*argv) + 2));
+    new_argv[0] = g_strdup (value);
+    for (i = 0; old_argv[i]; i++)
+        new_argv[i + 1] = old_argv[i];
+    new_argv[i + 1] = NULL;
+
+    g_free (*argv);
+    *argv = new_argv;
+}
+
 static Session *
 create_guest_session (Seat *seat)
 {
-    const gchar *session_name;
+    const gchar *session_name, *guest_wrapper;
     gchar *sessions_dir, **argv;
     SessionConfig *session_config;
     Session *session;
@@ -903,6 +920,15 @@
     session_set_do_authenticate (session, TRUE);
     session_set_is_guest (session, TRUE);
     argv = get_session_argv (seat, session_config, seat_get_string_property (seat, "session-wrapper"));
+    guest_wrapper = seat_get_string_property (seat, "guest-wrapper");
+    if (guest_wrapper)
+    {
+        gchar *path;
+        path = g_find_program_in_path (guest_wrapper);
+        prepend_argv (&argv, path ? path : guest_wrapper);
+        g_free (path);
+    }
+
     session_set_argv (session, argv);
     g_strfreev (argv);
     g_object_unref (session_config);
@@ -922,32 +948,11 @@
     return g_object_ref (session);
 }
 
-static void
-prepend_argv (gchar ***argv, const gchar *value)
-{
-    gchar **old_argv, **new_argv;
-    gint i;
-
-    old_argv = *argv;
-    new_argv = g_malloc (sizeof (gchar *) * (g_strv_length (*argv) + 2));
-    new_argv[0] = g_strdup (value);
-    for (i = 0; old_argv[i]; i++)
-        new_argv[i + 1] = old_argv[i];
-    new_argv[i + 1] = NULL;
-
-    g_free (*argv);
-    *argv = new_argv;
-}
-
 static gboolean
 greeter_start_session_cb (Greeter *greeter, SessionType type, const gchar *session_name, Seat *seat)
 {
     Session *session, *existing_session;
-    const gchar *username, *language = NULL;
-    SessionConfig *session_config;
-    User *user;
-    gchar *sessions_dir = NULL;
-    gchar **argv;
+    const gchar *username;
     DisplayServer *display_server;
 
     /* Get the session to use */
@@ -959,7 +964,54 @@
         session_set_pam_service (session, AUTOLOGIN_SERVICE);
     }
     else
+    {
+        const gchar *language = NULL;
+        SessionConfig *session_config;
+        User *user;
+        gchar *sessions_dir = NULL;
+        gchar **argv;
+
         session = greeter_get_authentication_session (greeter);
+  
+        /* Get session command to run */
+        switch (type)
+        {
+        case SESSION_TYPE_LOCAL:
+            sessions_dir = config_get_string (config_get_instance (), "LightDM", "sessions-directory");
+            break;
+        case SESSION_TYPE_REMOTE:
+            sessions_dir = config_get_string (config_get_instance (), "LightDM", "remote-sessions-directory");
+            break;
+        }
+
+        /* Load user preferences */
+        user = session_get_user (session);
+        if (user)
+        {
+            if (!session_name)
+                session_name = user_get_xsession (user);
+            language = user_get_language (user);
+        }
+
+        if (!session_name)
+            session_name = seat_get_string_property (seat, "user-session");
+        if (user)
+            user_set_xsession (session_get_user (session), session_name);
+
+        session_config = find_session_config (seat, sessions_dir, session_name);
+        g_free (sessions_dir);
+        if (!session_config)
+        {
+            l_debug (seat, "Can't find session '%s'", seat_get_string_property (seat, "user-session"));
+            return FALSE;
+        }
+
+        configure_session (session, session_config, session_name, language);
+        argv = get_session_argv (seat, session_config, seat_get_string_property (seat, "session-wrapper"));
+        session_set_argv (session, argv);
+        g_strfreev (argv);
+        g_object_unref (session_config);
+    }
 
     /* Switch to this session when it is ready */
     if (seat->priv->session_to_activate)
@@ -978,45 +1030,6 @@
         return TRUE;
     }
 
-    /* Get session command to run */
-    switch (type)
-    {
-    case SESSION_TYPE_LOCAL:
-        sessions_dir = config_get_string (config_get_instance (), "LightDM", "sessions-directory");
-        break;
-    case SESSION_TYPE_REMOTE:
-        sessions_dir = config_get_string (config_get_instance (), "LightDM", "remote-sessions-directory");
-        break;
-    }
-
-    /* Load user preferences */
-    user = session_get_user (session);
-    if (user)
-    {
-        if (!session_name)
-            session_name = user_get_xsession (user);
-        language = user_get_language (user);
-    }
-
-    if (!session_name)
-        session_name = seat_get_string_property (seat, "user-session");
-    if (user)
-        user_set_xsession (session_get_user (session), session_name);
-
-    session_config = find_session_config (seat, sessions_dir, session_name);
-    g_free (sessions_dir);
-    if (!session_config)
-    {
-        l_debug (seat, "Can't find session '%s'", seat_get_string_property (seat, "user-session"));
-        return FALSE;
-    }
-
-    configure_session (session, session_config, session_name, language);
-    argv = get_session_argv (seat, session_config, seat_get_string_property (seat, "session-wrapper"));
-    session_set_argv (session, argv);
-    g_strfreev (argv);
-    g_object_unref (session_config);
-
     /* If can re-use the display server, stop the greeter first */
     display_server = session_get_display_server (SESSION (greeter));
     if (can_share_display_server (seat, display_server) &&

=== modified file 'tests/Makefile.am'
--- tests/Makefile.am	2013-10-30 18:37:21 +0000
+++ tests/Makefile.am	2013-10-30 20:19:38 +0000
@@ -46,6 +46,7 @@
 	test-autologin-guest \
 	test-autologin-guest-fail-setup-script \
 	test-autologin-guest-logout \
+	test-guest-wrapper \
 	test-group-membership \
 	test-xdg-current-desktop \
 	test-xdg-seat \
@@ -339,6 +340,7 @@
 	scripts/greeter-wrapper.conf \
 	scripts/greeter-xserver-crash.conf \
 	scripts/group-membership.conf \
+	scripts/guest-wrapper.conf \
 	scripts/headless.conf \
 	scripts/home-dir-on-authenticate.conf \
 	scripts/home-dir-on-session.conf \

=== modified file 'tests/scripts/autologin-guest-in-background.conf'
--- tests/scripts/autologin-guest-in-background.conf	2013-10-21 22:43:11 +0000
+++ tests/scripts/autologin-guest-in-background.conf	2013-10-30 20:19:38 +0000
@@ -2,9 +2,6 @@
 # Check automatically logs in guest while keeping a greeter up
 #
 
-[LightDM]
-disable-guest-wrapper=true
-
 [SeatDefaults]
 autologin-guest=true
 autologin-in-background=true

=== modified file 'tests/scripts/autologin-guest-logout.conf'
--- tests/scripts/autologin-guest-logout.conf	2013-10-21 22:43:11 +0000
+++ tests/scripts/autologin-guest-logout.conf	2013-10-30 20:19:38 +0000
@@ -2,9 +2,6 @@
 # Check automatically logs in default user
 #
 
-[LightDM]
-disable-guest-wrapper=true
-
 [SeatDefaults]
 autologin-guest=true
 user-session=default

=== modified file 'tests/scripts/autologin-guest-timeout.conf'
--- tests/scripts/autologin-guest-timeout.conf	2013-10-21 22:43:11 +0000
+++ tests/scripts/autologin-guest-timeout.conf	2013-10-30 20:19:38 +0000
@@ -2,9 +2,6 @@
 # Check automatically logs in default user
 #
 
-[LightDM]
-disable-guest-wrapper=true
-
 [SeatDefaults]
 autologin-guest=true
 autologin-user-timeout=1

=== modified file 'tests/scripts/autologin-guest.conf'
--- tests/scripts/autologin-guest.conf	2013-10-03 21:28:05 +0000
+++ tests/scripts/autologin-guest.conf	2013-10-30 20:19:38 +0000
@@ -2,9 +2,6 @@
 # Check automatically logs in default user
 #
 
-[LightDM]
-disable-guest-wrapper=true
-
 [SeatDefaults]
 autologin-guest=true
 user-session=default

=== added file 'tests/scripts/guest-wrapper.conf'
--- tests/scripts/guest-wrapper.conf	1970-01-01 00:00:00 +0000
+++ tests/scripts/guest-wrapper.conf	2013-10-30 20:19:38 +0000
@@ -0,0 +1,37 @@
+#
+# Check guest wrapper works
+#
+
+[SeatDefaults]
+autologin-guest=true
+user-session=default
+guest-wrapper=test-guest-wrapper
+
+#?RUNNER DAEMON-START
+
+# X server starts
+#?XSERVER-0 START VT=7
+
+# Daemon connects when X server is ready
+#?*XSERVER-0 INDICATE-READY
+#?XSERVER-0 INDICATE-READY
+#?XSERVER-0 ACCEPT-CONNECT
+
+# Guest account created
+#?GUEST-ACCOUNT ADD USERNAME=guest-.*
+
+# Greeter wrapper starts
+#?GUEST-WRAPPER-X-0 START
+
+# Guest session starts
+#?SESSION-X-0 START XDG_SEAT=seat0 XDG_VTNR=7 DESKTOP_SESSION=default USER=guest-.*
+#?XSERVER-0 ACCEPT-CONNECT
+#?SESSION-X-0 CONNECT-XSERVER
+
+# Cleanup
+#?*STOP-DAEMON
+#?SESSION-X-0 TERMINATE SIGNAL=15
+#?XSERVER-0 TERMINATE SIGNAL=15
+#?GUEST-ACCOUNT REMOVE USERNAME=guest.*
+#?RUNNER DAEMON-EXIT STATUS=0
+

=== modified file 'tests/scripts/login-guest-logout.conf'
--- tests/scripts/login-guest-logout.conf	2013-10-21 22:43:11 +0000
+++ tests/scripts/login-guest-logout.conf	2013-10-30 20:19:38 +0000
@@ -2,9 +2,6 @@
 # Check automatically logs in default user
 #
 
-[LightDM]
-disable-guest-wrapper=true
-
 [SeatDefaults]
 user-session=default
 

=== modified file 'tests/scripts/login-guest.conf'
--- tests/scripts/login-guest.conf	2013-10-21 22:43:11 +0000
+++ tests/scripts/login-guest.conf	2013-10-30 20:19:38 +0000
@@ -2,9 +2,6 @@
 # Check can login as guest (not prompted for password)
 #
 
-[LightDM]
-disable-guest-wrapper=true
-
 [SeatDefaults]
 user-session=default
 

=== modified file 'tests/scripts/switch-to-guest.conf'
--- tests/scripts/switch-to-guest.conf	2013-10-03 21:28:05 +0000
+++ tests/scripts/switch-to-guest.conf	2013-10-30 20:19:38 +0000
@@ -2,9 +2,6 @@
 # Check D-Bus interface can trigger/switch to guest session
 #
 
-[LightDM]
-disable-guest-wrapper=true
-
 [SeatDefaults]
 autologin-user=have-password1
 user-session=default

=== modified file 'tests/src/Makefile.am'
--- tests/src/Makefile.am	2013-07-30 14:04:44 +0000
+++ tests/src/Makefile.am	2013-10-30 20:19:38 +0000
@@ -3,6 +3,7 @@
                   plymouth \
                   test-gobject-greeter \
                   test-greeter-wrapper \
+                  test-guest-wrapper \
                   test-mir-greeter \
                   test-runner \
                   test-script-hook \
@@ -96,6 +97,15 @@
 	$(GLIB_LIBS) \
 	$(GIO_UNIX_LIBS)
 
+test_guest_wrapper_SOURCES = test-guest-wrapper.c status.c status.h
+test_guest_wrapper_CFLAGS = \
+	$(WARN_CFLAGS) \
+	$(GLIB_CFLAGS) \
+	$(GIO_UNIX_CFLAGS)
+test_guest_wrapper_LDADD = \
+	$(GLIB_LIBS) \
+	$(GIO_UNIX_LIBS)
+
 test_gobject_greeter_SOURCES = test-gobject-greeter.c status.c status.h
 test_gobject_greeter_CFLAGS = \
 	-I$(top_srcdir)/liblightdm-gobject \

=== added file 'tests/src/test-guest-wrapper.c'
--- tests/src/test-guest-wrapper.c	1970-01-01 00:00:00 +0000
+++ tests/src/test-guest-wrapper.c	2013-10-30 20:19:38 +0000
@@ -0,0 +1,29 @@
+#include <stdlib.h>
+#include <unistd.h>
+
+#include "status.h"
+
+static void
+request_cb (const gchar *request)
+{
+}
+
+int
+main (int argc, char **argv)
+{
+    gchar *display;
+
+    status_connect (request_cb);
+
+    display = getenv ("DISPLAY");
+    if (display == NULL)
+        status_notify ("GUEST-WRAPPER-? START");
+    else if (display[0] == ':')
+        status_notify ("GUEST-WRAPPER-X-%s START", display + 1);
+    else
+        status_notify ("GUEST-WRAPPER-X-%s START", display);
+
+    execv (argv[1], argv + 1);
+
+    return EXIT_FAILURE;
+}

=== added file 'tests/test-guest-wrapper'
--- tests/test-guest-wrapper	1970-01-01 00:00:00 +0000
+++ tests/test-guest-wrapper	2013-10-30 20:19:38 +0000
@@ -0,0 +1,2 @@
+#!/bin/sh
+./src/dbus-env ./src/test-runner guest-wrapper test-gobject-greeter