Merge lp:~robert-ancell/libunity/update-deprecation-tags into lp:libunity

Proposed by Robert Ancell on 2018-08-18
Status: Merged
Approved by: Marco Trevisan (Treviño) on 2019-02-08
Approved revision: 331
Merged at revision: 333
Proposed branch: lp:~robert-ancell/libunity/update-deprecation-tags
Merge into: lp:libunity
Diff against target: 38 lines (+3/-3)
3 files modified
configure.ac (+1/-1)
debian/control (+1/-1)
src/unity-appinfo-manager.vala (+1/-1)
To merge this branch: bzr merge lp:~robert-ancell/libunity/update-deprecation-tags
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) 2018-08-18 Approve on 2019-02-01
Review via email: mp+353363@code.launchpad.net

Commit message

Update deprecated tag to recent format

To post a comment you must log in.
Marco Trevisan (Treviño) (3v1n0) wrote :

LGTM

review: Approve
Marco Trevisan (Treviño) (3v1n0) wrote :

I guess we also need a followup branch fixing dependency on valac, right?

Robert Ancell (robert-ancell) wrote :

Updated branch to bump version in debian/control.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2018-02-07 12:29:29 +0000
3+++ configure.ac 2019-02-03 22:37:00 +0000
4@@ -63,7 +63,7 @@
5 AM_PROG_CC_STDC
6 AC_HEADER_STDC
7 AM_PROG_LIBTOOL
8-AM_PROG_VALAC([0.18.0])
9+AM_PROG_VALAC([0.31.1])
10 AS_IF([test -z "$VALAC"], [AC_MSG_ERROR(["Can't find suitable vala compiler."])])
11
12 ###################################################################
13
14=== modified file 'debian/control'
15--- debian/control 2014-02-04 21:38:14 +0000
16+++ debian/control 2019-02-03 22:37:00 +0000
17@@ -9,7 +9,7 @@
18 autotools-dev,
19 pkg-config,
20 intltool,
21- valac (>= 0.22.0),
22+ valac (>= 0.31.1),
23 libglib2.0-dev (>= 2.32.1),
24 libdee-dev (>= 1.2.5~),
25 libdbusmenu-glib-dev (>= 0.4.90),
26
27=== modified file 'src/unity-appinfo-manager.vala'
28--- src/unity-appinfo-manager.vala 2016-05-16 23:12:22 +0000
29+++ src/unity-appinfo-manager.vala 2019-02-03 22:37:00 +0000
30@@ -97,7 +97,7 @@
31 });
32 }
33
34- [Deprecated (replacement = "AppInfoManager.get_default")]
35+ [Version (deprecated = true, replacement = "AppInfoManager.get_default")]
36 public static AppInfoManager get_instance ()
37 {
38 return AppInfoManager.get_default ();

Subscribers

People subscribed via source and target branches