Merge lp:~robert-ancell/indicator-session/use-xdg-seat-path into lp:indicator-session/0.1

Proposed by Robert Ancell
Status: Merged
Merged at revision: 218
Proposed branch: lp:~robert-ancell/indicator-session/use-xdg-seat-path
Merge into: lp:indicator-session/0.1
Diff against target: 55 lines (+2/-34)
1 file modified
src/users-service-dbus.c (+2/-34)
To merge this branch: bzr merge lp:~robert-ancell/indicator-session/use-xdg-seat-path
Reviewer Review Type Date Requested Status
Indicator Applet Developers Pending
Review via email: mp+76331@code.launchpad.net

Description of the change

Don't use depcrecated org.freedesktop.DisplayManager.GetSeatForCookie, use XDG_SEAT_PATH instead. GetSeatForCookie/GetSessionForCookie has been removed in LightDM 0.9.8.

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

I've put these methods back in for 0.9.8 so I can upgrade lightdm without this patch, but please apply it as I will remove these at some point.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/users-service-dbus.c'
2--- src/users-service-dbus.c 2011-09-08 09:23:55 +0000
3+++ src/users-service-dbus.c 2011-09-21 05:50:31 +0000
4@@ -203,40 +203,10 @@
5 create_display_manager_proxy (UsersServiceDbus *self)
6 {
7 UsersServiceDbusPrivate *priv = USERS_SERVICE_DBUS_GET_PRIVATE (self);
8- DBusGProxy *dm_proxy = NULL;
9 GError *error = NULL;
10- const gchar *cookie = NULL;
11- gchar *seat = NULL;
12+ const gchar *seat = NULL;
13
14- cookie = g_getenv ("XDG_SESSION_COOKIE");
15- if (cookie == NULL || cookie[0] == 0)
16- {
17- g_warning ("Failed to get DisplayManager proxy: XDG_SESSION_COOKIE undefined.");
18- return;
19- }
20-
21- dm_proxy = dbus_g_proxy_new_for_name (priv->system_bus,
22- "org.freedesktop.DisplayManager",
23- "/org/freedesktop/DisplayManager",
24- "org.freedesktop.DisplayManager");
25-
26- if (!dm_proxy)
27- {
28- g_warning ("Failed to get DisplayManager proxy.");
29- return;
30- }
31-
32- /* Now request the proper seat */
33- if (!dbus_g_proxy_call (dm_proxy, "GetSeatForCookie", &error,
34- G_TYPE_STRING, cookie, G_TYPE_INVALID,
35- DBUS_TYPE_G_OBJECT_PATH, &seat, G_TYPE_INVALID))
36- {
37- g_warning ("Failed to get DisplayManager seat proxy: %s", error->message);
38- g_object_unref (dm_proxy);
39- g_error_free (error);
40- return;
41- }
42- g_object_unref (dm_proxy);
43+ seat = g_getenv ("XDG_SEAT_PATH");
44 g_debug ("CREATING DM PROXIES WITH %s", seat);
45 priv->display_manager_proxy = dbus_g_proxy_new_for_name (priv->system_bus,
46 "org.freedesktop.DisplayManager",
47@@ -249,8 +219,6 @@
48 "org.freedesktop.DBus.Properties");
49
50
51- g_free (seat);
52-
53 if (!priv->display_manager_proxy)
54 {
55 g_warning ("Failed to get DisplayManager seat proxy.");

Subscribers

People subscribed via source and target branches