Merge lp:~robert-ancell/indicator-session/unity-settings-daemon into lp:indicator-session/14.04

Proposed by Robert Ancell
Status: Merged
Approved by: Charles Kerr
Approved revision: 430
Merged at revision: 432
Proposed branch: lp:~robert-ancell/indicator-session/unity-settings-daemon
Merge into: lp:indicator-session/14.04
Diff against target: 12 lines (+1/-1)
1 file modified
debian/control (+1/-1)
To merge this branch: bzr merge lp:~robert-ancell/indicator-session/unity-settings-daemon
Reviewer Review Type Date Requested Status
Dimitri John Ledkov Approve
PS Jenkins bot (community) continuous-integration Approve
Charles Kerr (community) Approve
Review via email: mp+205421@code.launchpad.net

Commit message

Only depend on gnome-settings-daemon-schemas so can work with unity-settings-daemon only

To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

DONE * Ensure the project compiles and the test suite executes without error
DONE * Ensure that non-obvious code has comments explaining it
DONE * If the change works on specific profiles, please include those in the merge description. (no profile specific changes)

DONE * Did the Jenkins build compile? Pass? Run unit tests successfully?
DONE * Are there appropriate tests to cover any new functionality?

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

DONE * Run tests indicator-session/unity7

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

SKIP * Run tests indicator-session/unity8*
no phone profile / no session indicator as per test-case.

review: Approve
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Please land this branch into the archive.

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Is Jenkins confused? This should have landed right?

Revision history for this message
Sebastien Bacher (seb128) wrote :

@Robert: no, landing doesn't happen that way anymore with CI train. A lander needs to list the vcs-es to land, the system gives you a ppa to test in return and only if you flag it as good the changes are uploaded and merged back in trunk...

I'm going to drive a landing request for that one today

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-01-14 04:41:16 +0000
3+++ debian/control 2014-02-07 16:55:56 +0000
4@@ -24,7 +24,7 @@
5 Depends: ${shlibs:Depends},
6 ${misc:Depends},
7 systemd-services,
8- gnome-settings-daemon,
9+ gnome-settings-daemon-schemas,
10 Recommends: indicator-applet (>= 0.2) | indicator-renderer,
11 gnome-screensaver,
12 yelp,

Subscribers

People subscribed via source and target branches