Merge lp:~robert-ancell/indicator-power/ucc-only-in-unity into lp:indicator-power/14.04
Status: | Rejected |
---|---|
Rejected by: | Sebastien Bacher on 2014-01-22 |
Proposed branch: | lp:~robert-ancell/indicator-power/ucc-only-in-unity |
Merge into: | lp:indicator-power/14.04 |
Diff against target: |
12 lines (+1/-1) 1 file modified
src/service.c (+1/-1) |
To merge this branch: | bzr merge lp:~robert-ancell/indicator-power/ucc-only-in-unity |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sebastien Bacher | Disapprove on 2014-01-22 | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing on 2014-01-22 | |
Ted Gould (community) | 2014-01-21 | Approve on 2014-01-22 | |
Review via email:
|
Commit message
Only run unity-control-
Robert Ancell (robert-ancell) wrote : | # |
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:222
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
Sebastien Bacher (seb128) wrote : | # |
Hum, I'm not sure that's the right thing to do (it also make me wonder if we should have prefixed the control center with "ubuntu" rather than "unity"). In practice it feels like that GNOME sessions are going to use g-c-c and that other sessions might want to use u-c-c (including GNOME classic and XFCE since they use some indicators)...
Ted Gould (ted) wrote : | # |
Talked with seb on IRC about this. We're going to leave it like this for now, but eventually phase out g-c-c support as it doesn't make sense. But that's needed as a migration path today.
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Sebastien Bacher (seb128) wrote : | # |
The change there shouldn't be needed/is superseeded by http://
Unmerged revisions
- 222. By Robert Ancell on 2014-01-21
-
Only run unity-control-
center under unity
This updates the recent merge to match the updated behaviour of the other indicators at Ted's request.