Code review comment for ~robbat2/cirros:gentoo

Scott Moser (smoser) wrote :

Thanks for putting together a merge propsal.
A tiny things:
 - fixes comments are done with:
   LP: #XXXXXX

Generally I dont have interest in just adding lots of modules,
as that makes things bigger. I've not looked at the size change
that would be caused, so I dont know specifically about these
modules.

Specifically for the Hyper-v modules there is an issue that
loading those modules causes 5 second delay even if the hardware
is not there. Unless that is now known fixed, then we can't
really just add them to the list as they have a negative affect
everywhere.

I'm generally OK with the powerpc changes.

the BR_VERSION change is probably not really all that useful in
reality. Its quite a pain to move buildroot versions (more
than just changing that file :)

« Back to merge proposal