Merge lp:~roadmr/ubuntu/precise/checkbox/0.13.9 into lp:ubuntu/precise-proposed/checkbox

Proposed by Daniel Manrique
Status: Merged
Merged at revision: 45
Proposed branch: lp:~roadmr/ubuntu/precise/checkbox/0.13.9
Merge into: lp:ubuntu/precise-proposed/checkbox
Diff against target: 44 lines (+9/-6)
3 files modified
checkbox/user_interface.py (+1/-1)
debian/changelog (+7/-0)
scripts/camera_test (+1/-5)
To merge this branch: bzr merge lp:~roadmr/ubuntu/precise/checkbox/0.13.9
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
Review via email: mp+135265@code.launchpad.net

Description of the change

Hello! This is an update of the checkbox 0.13.8 SRU, taking care of two 0.13.8 bugs that failed verification (one was missing code, so I added it; the code for the other didn't fix the bug and needs more work and a closer look, so I removed it). I also updated the changelog to bump the version to 0.13.9.

Merge requested on -proposed directly, with just the changes that need to be applied on top of 0.13.8. Let me know if this is OK, also I didn't request a "candidate revision" bug as per previous SRU uploads I've requested, but if this needs to be done, also please let me know.

Thanks!

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Everything is perfect Daniel procedure-wise. Thanks, merging it and uploading to -proposed :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox/user_interface.py'
2--- checkbox/user_interface.py 2012-10-02 17:18:22 +0000
3+++ checkbox/user_interface.py 2012-11-20 22:17:32 +0000
4@@ -176,7 +176,7 @@
5 subprocess.Popen(sudo_prefix + [browser.group(0), "--new-window", url])
6 return
7
8- browser = re.match("(chromium-browser[^\s]*)", preferred_browser)
9+ browser = re.match(".*(chromium-browser[^\s]*)", preferred_browser)
10 if browser:
11 subprocess.Popen(sudo_prefix + [browser.group(0), "--allow-file-access-from-files", url])
12 return
13
14=== modified file 'debian/changelog'
15--- debian/changelog 2012-10-02 17:18:22 +0000
16+++ debian/changelog 2012-11-20 22:17:32 +0000
17@@ -1,3 +1,10 @@
18+checkbox (0.13.9) precise-proposed; urgency=low
19+
20+ * Updated fix for bug #1026614 which was missing some code.
21+ * Removed bad fix for bug 990133.
22+
23+ -- Daniel Manrique <roadmr@ubuntu.com> Tue, 20 Nov 2012 16:31:02 -0500
24+
25 checkbox (0.13.8) precise-proposed; urgency=low
26
27 * New upstream release (LP: #1061198)
28
29=== modified file 'scripts/camera_test'
30--- scripts/camera_test 2012-10-02 17:18:22 +0000
31+++ scripts/camera_test 2012-11-20 22:17:32 +0000
32@@ -89,11 +89,7 @@
33 self._pipeline.set_state(gst.STATE_PLAYING)
34 time.sleep(3)
35 self._pipeline.set_state(gst.STATE_READY)
36- try:
37- call(["timeout", "-k", "11", "10", "eog", filename])
38- except CalledProcessError:
39- pass
40-
41+ call(["eog", file.name])
42
43 def parse_arguments(argv):
44 """

Subscribers

People subscribed via source and target branches