Code review comment for lp:~roadmr/ubuntu/precise/checkbox/0.13.1

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

 - I see there are extra changes for a checkbox-sru script; they should either be added to changelog or dropped.

- There are also extra changes in install/postinst for update_configuration() (third hunk in the diff) that weren't immediately obvious to me what they were for besides the dropped hwtest packages. They should be better described in changelog (if not already there).

- there is no mention of the changes to jobs/local.txt.in for the command; changing from .../peripheral.txt to .../phoronix.txt looks rather unusual; and should be mentioned in syslog.

- changes to plugins/jobs_prompt.py aren't changelog, afaict; please add them :)

- there appears to be extra changes to scripts/cpu_offlining; again not in changelog when they should probably be.

review: Needs Fixing

« Back to merge proposal