Merge lp:~roadmr/ubuntu/oneiric/checkbox/0.12.10 into lp:ubuntu/oneiric-proposed/checkbox

Proposed by Daniel Manrique
Status: Merged
Merge reported by: Mathieu Trudel-Lapierre
Merged at revision: not available
Proposed branch: lp:~roadmr/ubuntu/oneiric/checkbox/0.12.10
Merge into: lp:ubuntu/oneiric-proposed/checkbox
Diff against target: 55 lines (+18/-3)
3 files modified
debian/changelog (+11/-0)
jobs/bluetooth.txt.in (+6/-2)
scripts/connect_wireless (+1/-1)
To merge this branch: bzr merge lp:~roadmr/ubuntu/oneiric/checkbox/0.12.10
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Pending
Review via email: mp+94813@code.launchpad.net

Description of the change

This fixes the code for the two 0.12.9 bugs that failed verification (one was missing code, so I added it; the code for the other didn't fix the bug, so I removed it). I also re-added one dependency that got removed by mistake and updated the changelog to bump the version to 0.12.10.

Merge requested on -proposed directly, with just the changes that need to be applied on top of 0.12.9.

Thanks!

To post a comment you must log in.
38. By Daniel Manrique

Restored 0.12.9 changelog and added reverted code description to 0.12.10

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

I think this got merged; I'll set the state to merged.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-12-02 16:49:05 +0000
3+++ debian/changelog 2012-02-28 18:49:17 +0000
4@@ -1,3 +1,14 @@
5+checkbox (0.12.10) oneiric-proposed; urgency=low
6+
7+ [Brendan Donegan]
8+ * Have the bluetooth/detect tests require a device with the category
9+ BLUETOOTH to run, thus preventing the test from failing on systems with
10+ no Bluetooth device (LP: #862322)
11+ * Remove fix for bug 877752 on connect_wireless, as it was not working as
12+ intended.
13+
14+ -- Daniel Manrique <daniel.manrique@canonical.com> Tue, 07 Feb 2012 15:30:36 -0500
15+
16 checkbox (0.12.9) oneiric-proposed; urgency=low
17
18 [Brendan Donegan]
19
20=== modified file 'jobs/bluetooth.txt.in'
21--- jobs/bluetooth.txt.in 2011-09-01 12:23:07 +0000
22+++ jobs/bluetooth.txt.in 2012-02-28 18:49:17 +0000
23@@ -1,13 +1,17 @@
24 plugin: shell
25 name: bluetooth/detect
26-requires: package.name == 'bluez'
27+requires:
28+ package.name == 'bluez'
29+ device.category == 'BLUETOOTH'
30 command: hcitool dev | tail -n+2 | awk '{print $2}' |grep -E "^([0-9a-fA-F]{2}\:){5}[0-9a-fA-F]{2}$"
31 _description:
32 Output address of detected Bluetooth device, if any, or exits with error if none is found.
33
34 plugin: shell
35 name: bluetooth/detect-output
36-requires: package.name == 'bluez'
37+requires:
38+ package.name == 'bluez'
39+ device.category == 'BLUETOOTH'
40 command: hcitool dev | tail -n+2 | awk '{print $2}'; hcitool dev | tail -n+2 | awk '{print $2}' > $CHECKBOX_DATA/bluetooth_address
41 _description:
42 Automated test to store output in checkbox report
43
44=== modified file 'scripts/connect_wireless'
45--- scripts/connect_wireless 2011-12-02 16:49:05 +0000
46+++ scripts/connect_wireless 2012-02-28 18:49:17 +0000
47@@ -8,7 +8,7 @@
48 if [ $? -eq 0 ]
49 then
50 ap=$(echo $active_connection | awk -F\' '{print $2}')
51- conn=$(nmcli -t -f UUID,NAME,TYPE con list | grep wireless | grep -e "$ap$" | awk -F\: '{print $1}')
52+ conn=$(nmcli -t -f UUID,NAME con list | grep -e "$ap$" | awk -F\: '{print $1}')
53 else
54 conn=$(nmcli -t -f UUID,TYPE con list | grep wireless | head -n 1 | awk -F\: '{print $1}')
55 fi

Subscribers

People subscribed via source and target branches