Merge lp:~roadmr/ols-jenkaas/is-snapcraft-ci-macaroon-stale into lp:~ols-jenkaas-admins/ols-jenkaas/trunk

[Daniel Manrique]

Message and failfast if the candid macaroon for snapcraft-ci is stale.

This should prevent headscratching when snapcraft-ci fails.

[Daniel Manrique (roadmr)]

The addition is this oneliner:

if [ "$(find ~/secrets/snapcraft-ci/store-testing-creds.dat -ctime -29)" = "" ]; then echo "Candid macaroon is older than 29 days, failing fast. Generate a new macaroon with ols-jenkaas-secrets"; exit 1; else echo "Candid macaroon is fresh enough, continuing";fi

[Maximiliano Bertacchini (maxiberta)]

LGTM +1

review: Approve

=== modified file 'jobs/snapcraft-ci.yaml'
--- jobs/snapcraft-ci.yaml	2021-03-29 16:06:15 +0000
+++ jobs/snapcraft-ci.yaml	2021-10-07 20:02:34 +0000
@@ -4,7 +4,7 @@
     vcs: 'git'
     trunk: 'https://github.com/snapcore/snapcraft.git'
     setup: 'git clone lp:~roadmr/+git/spread'
-    acceptance-tests: 'SNAP_STORE_MACAROON=$(base64 -w0 ~/secrets/snapcraft-ci/store-testing-creds.dat) SNAP_STORE_CANDID_MACAROON=$(base64 -w0 ~/secrets/snapcraft-ci/store-testing-candid-creds.dat)  SNAPCRAFT_CHANNEL=candidate spread/spread lxd:ubuntu-18.04:tests/spread/general/store'
+    acceptance-tests: 'if [ "$(find ~/secrets/snapcraft-ci/store-testing-creds.dat -ctime -29)" = "" ]; then echo "Candid macaroon is older than 29 days, failing fast. Generate a new macaroon with ols-jenkaas-secrets"; exit 1; else echo "Candid macaroon is fresh enough, continuing";fi;SNAP_STORE_MACAROON=$(base64 -w0 ~/secrets/snapcraft-ci/store-testing-creds.dat) SNAP_STORE_CANDID_MACAROON=$(base64 -w0 ~/secrets/snapcraft-ci/store-testing-candid-creds.dat)  SNAPCRAFT_CHANNEL=candidate spread/spread lxd:ubuntu-18.04:tests/spread/general/store'
     jobs:
       - '{name}-tests'