Merge lp:~roadmr/django-saml2-idp/fix-bogus-subject into lp:~ubuntuone-pqm-team/django-saml2-idp/stable

[Daniel Manrique]

Remove a stray, bogus $SUBJECT substitution that was generating invalid SAML assertions.

This resulted in errors like this from SPs which validate the SAML responses:

Errors validating the metadata:

Element '{urn:oasis:names:tc:SAML:2.0:assertion}AttributeStatement': Character content other than whitespace is not allowed because the content type is 'element-only'.
Invalid SAML Response. Not match the saml-schema-protocol-2.0.xsd

I tried/am trying to run the tests for this project but they appear to be rotten. This is tested in the next layer in https://code.launchpad.net/~roadmr/canonical-identity-provider/validate-saml-xml/+merge/333276, which will actually not pass until it references django-saml2-idp with this fix merged.

Remove a stray, bogus $SUBJECT substitution that was generating invalid SAML assertions.

This resulted in errors like this from SPs which validate the SAML responses:

Errors validating the metadata:

Element '{urn:oasis:names:tc:SAML:2.0:assertion}AttributeStatement': Character content other than whitespace is not allowed because the content type is 'element-only'.
Invalid SAML Response. Not match the saml-schema-protocol-2.0.xsd

I tried/am trying to run the tests for this project but they appear to be rotten. This is tested in the next layer in https://code.launchpad.net/~roadmr/canonical-identity-provider/validate-saml-xml/+merge/333276, which will actually not pass until it references django-saml2-idp with this fix merged.

[Ricardo Kirkner (ricardokirkner)]

LGTM

review: Approve

=== modified file 'idptest/saml2idp/xml_templates.py'
--- idptest/saml2idp/xml_templates.py	2012-06-27 20:26:38 +0000
+++ idptest/saml2idp/xml_templates.py	2017-11-06 21:25:24 +0000
@@ -51,7 +51,6 @@
 
 ATTRIBUTE_STATEMENT = (
     '<saml:AttributeStatement>'
-    '${SUBJECT}'
     '${ATTRIBUTES}'
     '</saml:AttributeStatement>'
 )