Merge lp:~roadmr/checkbox/revert-graphics-card-resource-space-eater into lp:checkbox

Proposed by Daniel Manrique
Status: Merged
Approved by: Daniel Manrique
Approved revision: 3594
Merged at revision: 3595
Proposed branch: lp:~roadmr/checkbox/revert-graphics-card-resource-space-eater
Merge into: lp:checkbox
Diff against target: 24 lines (+0/-7)
1 file modified
providers/plainbox-provider-resource-generic/bin/graphics_card_resource (+0/-7)
To merge this branch: bzr merge lp:~roadmr/checkbox/revert-graphics-card-resource-space-eater
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+251143@code.launchpad.net

Commit message

Reverts the previously-merged graphics_card_resource product name hack, as it was deemed inadequate post-merge.

Description of the change

Reverts the previously-merged graphics_card_resource hack, as it was deemed inadequate post-merge.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

Self-approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'providers/plainbox-provider-resource-generic/bin/graphics_card_resource'
2--- providers/plainbox-provider-resource-generic/bin/graphics_card_resource 2015-02-25 22:39:28 +0000
3+++ providers/plainbox-provider-resource-generic/bin/graphics_card_resource 2015-02-26 18:47:02 +0000
4@@ -18,7 +18,6 @@
5 # along with Checkbox. If not, see <http://www.gnu.org/licenses/>.
6
7 import argparse
8-import re
9 import subprocess
10 import shlex
11
12@@ -116,12 +115,6 @@
13 except ValueError:
14 fake_product = "PCI ID unknown"
15 record['product'] = fake_product
16- # replace characters that would make for an invalid job id
17- record['product'] = re.sub(r"[^_a-zA-Z0-9-]",
18- "",
19- record['product'].replace(
20- " ",
21- "_"))
22 # Finally, print the record
23 items = ["{key}: {value}".format(key=k, value=record[k])
24 for k in sorted(record.keys())]

Subscribers

People subscribed via source and target branches