Merge lp:~roadmr/checkbox/ppcg-libqt5xml5-dep into lp:~checkbox-dev/checkbox/ppa-packaging-checkbox-gui

Proposed by Daniel Manrique
Status: Rejected
Rejected by: Daniel Manrique
Proposed branch: lp:~roadmr/checkbox/ppcg-libqt5xml5-dep
Merge into: lp:~checkbox-dev/checkbox/ppa-packaging-checkbox-gui
Diff against target: 11 lines (+1/-0)
1 file modified
debian/control (+1/-0)
To merge this branch: bzr merge lp:~roadmr/checkbox/ppcg-libqt5xml5-dep
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Disapprove
Zygmunt Krynicki (community) Needs Information
Review via email: mp+232310@code.launchpad.net

Commit message

Added dependency on libqt5xml5 which is present on Ubuntu but not on other flavors

Description of the change

Added dependency on libqt5xml5 which is present on Ubuntu but not on other flavors

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

This is something I don't quite understand. What's using qt5xml5? Is it us? Why is it not caught by ${shlibs:Depends}. If it's not us then isn't this a bug in one of our dependencies?

review: Needs Information
Revision history for this message
Daniel Manrique (roadmr) wrote :

No, you're right, see my last comment in the bug.

PPA packaging is correct, I need to fix *ubuntu* packaging.

I'll reject this MR myself. Thanks for catching this!

review: Disapprove

Unmerged revisions

8. By Daniel Manrique

Added dependency on libqt5xml5 which is present on Ubuntu but not on other flavors

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-04-16 19:06:39 +0000
3+++ debian/control 2014-08-26 20:01:27 +0000
4@@ -18,6 +18,7 @@
5 ${misc:Depends},
6 ${shlibs:Depends},
7 checkbox-ng-service (>= 0.3),
8+ libqt5xml5,
9 plainbox-provider-checkbox (>= 0.4),
10 qtdeclarative5-localstorage-plugin,
11 qtdeclarative5-qtquick2-plugin,

Subscribers

People subscribed via source and target branches