Merge lp:~roadmr/checkbox/plainbox-packaging-dbus-dependencies into lp:~checkbox-dev/checkbox/plainbox-packaging

[Daniel Manrique]

Recent plainbox builds are failing, ostensibly because during testing, plainbox/impl/service.py wants to include dbus, which is not declared as a dependency and thus not installed.

While it's strictly a Build-Depends, I also added it as a Depends since this will eventually be one of the main ways to use plainbox.

Let me know if it would be preferrable to remove the runtime dependency on dbus (not the build one), and instead add that dependency in i.e. GUI clients that communicate through dbus.

Recent plainbox builds are failing, ostensibly because during testing, plainbox/impl/service.py wants to include dbus, which is not declared as a dependency and thus not installed.

While it's strictly speaking only needed as a Build-Depends, I also added it as a Depends since this will eventually be one of the main ways to use plainbox.

Let me know if it would be preferrable to remove the runtime dependency on dbus (not the build one), and instead add that dependency in i.e. GUI clients that communicate through dbus.

[Zygmunt Krynicki (zyga)]

Thanks for looking at the packaging. I think I'd like to have plainbox-service as a standalone package, that ships the .service file and perhaps a small dedicated executable just for that. I'd rather not pull python3-dbus and the rest of dbus just for python3-plainbox.

Thanks

[Daniel Manrique (roadmr)]

That makes sense, I'll amend this to add only the build-depends.

I'm still having trouble with the build, the test_run and test_sru tests fail due to trouble creating a log file (try it in a local pbuilder or sbuild if you're curious). I'll work on fixing all in one go, no point in submitting a fix that half-works :)

[Sylvain Pineau (sylvain-pineau)]

+1 for having a dedicated service package, cli based clients won't need dbus (they could of course but python3-plainbox doesn’t need to have a runtime dep on dbus).

[lp:~roadmr/checkbox/plainbox-packaging-dbus-dependencies]

13. By Daniel Manrique on 2013-07-14

Added python3-dbus and python3-gi as Build-Depends so build-time tests pass

[Daniel Manrique (roadmr)]

Hey! so I resubmitted with a change to have dbus and gi as Build-Depends only.

Note that it will still not build due with another problem in the logging module which I'm still investigating (I know why it happens, I just need to code a solution). But if you want to approve this so it's ready when the fix for the logging problem lands, it should be OK. Thanks!

review: Needs Resubmitting

[Zygmunt Krynicki (zyga)]

Yup, looks good. +1

Would you mind looking at packaging the service file?

review: Approve

=== modified file 'debian/control'
--- debian/control	2013-05-10 12:42:12 +0000
+++ debian/control	2013-07-15 13:18:24 +0000
@@ -5,6 +5,8 @@
 Build-Depends: checkbox,
                debhelper (>= 8.0.0),
                python3-all,
+               python3-dbus,
+               python3-gi,
                python3-lxml,
                python3-mock,
                python3-pkg-resources,