Merge lp:~roadmr/checkbox/packaging-ubuntu-sdk-build-depends-fix into lp:~checkbox-dev/checkbox/checkbox-packaging

[Daniel Manrique]

This implements Brendan's idea about removing ubuntu-sdk as a build-depends, and instead spelling out the packages it pulls. In the process I removed some unneeded packages such as qmlscene, documentation, examples, qtcreator and qtcreator plugins (since it's just for command-line building, those tools aren't needed).

This implements Brendan's idea about removing ubuntu-sdk as a build-depends, and instead spelling out the packages it pulls. In the process I removed some unneeded packages such as qmlscene, documentation, examples, qtcreator and qtcreator plugins (since it's just for command-line building, those tools aren't needed).

I tested it in a local sbuild using precise and saucy (to test the LTS and latest stable release), and it was able to build packages correctly.

[Daniel Manrique (roadmr)]

I'll self-approve this based on my local testing results, to see if I can unblock builds (hey, it's not building anyway so I can't really break it more). Still, please review for sanity.

review: Approve

[Zygmunt Krynicki (zyga)]

Looks good, I'd +1 it as well. I have a few questions though:

+ cordova-ubuntu-2.8,
+ cordova-ubuntu-2.8-dev,

Why do we build depend on that? We're certainly *not* using cordova.

+Build-Depends: click,
+ click-dev,

As above

43 + ubuntu-html5-theme,

As above

review: Needs Information

[Daniel Manrique (roadmr)]

Hi! Removed the above as well as ubuntu-ui-toolkit-theme, and the build still succeeds so I'll propose a merge with those changes. Thanks!

=== modified file 'debian/control'
--- debian/control	2013-12-13 14:26:50 +0000
+++ debian/control	2013-12-15 17:55:55 +0000
@@ -5,9 +5,19 @@
 Standards-Version: 3.9.3
 X-Python3-Version: >= 3.2
 XS-Testsuite: autopkgtest
-Build-Depends: debhelper (>= 9.2),
+Build-Depends: click,
+               click-dev,
+               cordova-ubuntu-2.8,
+               cordova-ubuntu-2.8-dev,
+               debhelper (>= 9.2),
                dh-translations,
                libqt4-dev,
+               libqt5qml-graphicaleffects,
+               libqt5sql5-sqlite,
+               libqt5svg5-dev,
+               libqt5v8-5-dev,
+               libqt5webkit5-dev,
+               libqt5xmlpatterns5-dev,
                po-debconf,
                python,
                python-distutils-extra,
@@ -21,8 +31,21 @@
                python3-requests ( >= 1.0),
                python3-setuptools,
                python3-sphinx,
+               qt3d5-dev,
                qt4-qmake,
-               ubuntu-sdk
+               qt5-default,
+               qtbase5-dev,
+               qtdeclarative5-cordova-2.8-plugin,
+               qtdeclarative5-dev,
+               qtdeclarative5-dev-tools,
+               qtlocation5-dev,
+               qtmultimedia5-dev,
+               qtscript5-dev,
+               qtsensors5-dev,
+               qttools5-dev,
+               qttools5-dev-tools,
+               ubuntu-html5-theme,
+               ubuntu-ui-toolkit-theme
 Vcs-Bzr: https://code.launchpad.net/~checkbox-dev/checkbox/checkbox-packaging
 
 Package: python3-plainbox-doc