Merge lp:~roadmr/checkbox/packaging-checkbox-gui-arch-support into lp:~checkbox-dev/checkbox/checkbox-packaging

[Daniel Manrique]

uild checkbox-gui only on supported architectures (i386, amd64, armhf).

The reason the others are unsupported is that the qt5declarative set of
packages depends on the v8 javascript engine which is unavailable for those
architectures. If/when this dependency becomes available we can either remove
these restrictions or leave the supported arch list "empty".

Build checkbox-gui only on supported architectures (i386, amd64, armhf).

The reason the others are unsupported is that the qt5declarative set of
packages depends on the v8 javascript engine which is unavailable for those
architectures. If/when this dependency becomes available we can either remove
these restrictions or leave the supported arch list "empty".

[Sylvain Pineau (sylvain-pineau)]

+1 for me.

review: Approve

=== modified file 'debian/changelog'
--- debian/changelog	2014-02-12 20:11:56 +0000
+++ debian/changelog	2014-02-13 16:06:36 +0000
@@ -15,6 +15,13 @@
   * Removed build dependencies on qt{multimedia,sensors}5-dev as they're not
     actually needed.
   * Minor rearranging of checkbox-gui dependencies.
+  * Ignore some build-depends on a few architectures where they're
+    unavailable.
+  * Declare specific architectures for which the checkbox-gui binary package
+    can be built.
+  * Make rules file conditionally build, install and package checkbox-gui
+    files only on supported archs.
+
 
  -- Zygmunt Krynicki <[e-mail]>  Tue, 28 Jan 2014 03:15:31 +0100
 

=== modified file 'debian/control'
--- debian/control	2014-02-12 20:11:56 +0000
+++ debian/control	2014-02-13 16:06:36 +0000
@@ -9,11 +9,11 @@
                dh-translations,
                libnl-genl-3-dev,
                libqt4-dev,
-               libqt5qml-graphicaleffects,
+               libqt5qml-graphicaleffects [!arm64 !powerpc !ppc64el],
                libqt5sql5-sqlite,
                libqt5svg5-dev,
-               libqt5v8-5-dev,
-               libqt5webkit5-dev,
+               libqt5v8-5-dev [!arm64 !powerpc !ppc64el],
+               libqt5webkit5-dev [!arm64 !powerpc !ppc64el],
                libqt5xmlpatterns5-dev,
                po-debconf,
                python,
@@ -28,13 +28,13 @@
                python3-requests ( >= 1.0),
                python3-setuptools,
                python3-sphinx,
-               qt3d5-dev,
+               qt3d5-dev [!arm64 !powerpc !ppc64el],
                qt4-qmake,
                qt5-default,
                qtbase5-dev,
-               qtdeclarative5-dev,
-               qtdeclarative5-dev-tools,
-               qtlocation5-dev,
+               qtdeclarative5-dev [!arm64 !powerpc !ppc64el],
+               qtdeclarative5-dev-tools [!arm64 !powerpc !ppc64el],
+               qtlocation5-dev [!arm64 !powerpc !ppc64el],
                qtscript5-dev,
                qttools5-dev,
                qttools5-dev-tools
@@ -426,7 +426,7 @@
  checkbox-certification-server
 
 Package: checkbox-gui
-Architecture: any
+Architecture: i386 armhf amd64
 Depends: checkbox-ng-service,
          plainbox-provider-checkbox,
          qtdeclarative5-localstorage-plugin,

=== modified file 'debian/rules'
--- debian/rules	2013-12-13 18:12:06 +0000
+++ debian/rules	2014-02-13 16:06:36 +0000
@@ -7,7 +7,9 @@
 
 REL_NO	:= $(shell lsb_release -rs)
 RELEASE_GTE_RARING	:= $(shell expr $(REL_NO) \>= 13.04)
-
+# The checkbox-gui binary only makes sense to build for the following
+# architectures.
+GUI_ARCHS := amd64 armhf i386
 %:
 	dh "$@" --with python3,sphinxdoc,translations
 
@@ -35,7 +37,12 @@
 	echo "from unittest.mock import *" > $(CURDIR)/plainbox/plainbox/vendor/mock.py
 	dh_quilt_patch
 endif
+ifneq (,$(findstring $(DEB_BUILD_ARCH), $(GUI_ARCHS)))
 	cd $(CURDIR)/checkbox-gui && qmake PREFIX=/usr && make
+	$(warning NOTICE: Building GUI on supported architecture)
+else
+	$(warning NOTICE: NOT building GUI on unsupported architecture)
+endif
 	python3 setup.py build
 
 ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
@@ -55,7 +62,9 @@
 	python3 setup.py install --root=$(CURDIR)/debian/tmp --install-layout=deb
 	mkdir -p $(CURDIR)/debian/tmp/usr/lib/checkbox/bin/
 	cp -R $(CURDIR)/debian/tmp/usr/share/checkbox/scripts/* $(CURDIR)/debian/tmp/usr/lib/checkbox/bin/
+ifneq (,$(findstring $(DEB_BUILD_ARCH), $(GUI_ARCHS)))
 	cd $(CURDIR)/checkbox-gui && make INSTALL_ROOT=$(CURDIR)/debian/tmp install
+endif
 	dh_install
 
 override_dh_installdocs:
@@ -73,7 +82,9 @@
 	# dh_python3 runs automatically on packages with the python3- prefix
 	# let's not forget plainbox
 	dh_python3 --package=plainbox
+ifneq (,$(findstring $(DEB_BUILD_ARCH), $(GUI_ARCHS)))
 	dh_python3 --no-package=checkbox-gui
+endif
 
 override_dh_installdeb:
 	cp debian/checkbox.postrm debian/checkbox-cli.postrm