Merge lp:~roadmr/checkbox/packaging-1206016-fwts-version into lp:~checkbox-dev/checkbox/checkbox-packaging

Proposed by Daniel Manrique
Status: Merged
Approved by: Brendan Donegan
Approved revision: 16
Merged at revision: 16
Proposed branch: lp:~roadmr/checkbox/packaging-1206016-fwts-version
Merge into: lp:~checkbox-dev/checkbox/checkbox-packaging
Diff against target: 12 lines (+1/-1)
1 file modified
debian/control (+1/-1)
To merge this branch: bzr merge lp:~roadmr/checkbox/packaging-1206016-fwts-version
Reviewer Review Type Date Requested Status
Po-Hsu Lin Approve
Brendan Donegan (community) Approve
Review via email: mp+185055@code.launchpad.net

Commit message

A small tweak for the packaging branch, requiring a specific fwts version for checkbox (to ensure we get at least that one).

Description of the change

A small tweak for the packaging branch, requiring a specific fwts version for checkbox (to ensure we get at least that one).

To post a comment you must log in.
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

+1

review: Approve
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Oh, sorry, I didn't make it clear in the comment of bug 1206016

dmesg_common was removed from fwts since 0.26.08-0ubuntu1 (and this version is for raring).

So for precise, I think the working version is 0.25.06precise1

review: Needs Fixing
Revision history for this message
Daniel Manrique (roadmr) wrote :

Hi Po-Hsu,

We have fwts 13.08.00 for Precise in the PPA, so if on a Precise system, you install checkbox from the PPA, fwts 13.08.00 will also be installed from PPA to satisfy the dependency.

Users who don't have the PPA will not be affected by this change because this update will not make it into any stable Ubuntu release (at least not until 13.10 is released).

Are you OK with this?

Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Sorry I mis-understood this merge, if we remove the dmesg_common, then version 0.26.08-0ubuntu1 will be OK for this.
Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-07-03 20:38:00 +0000
3+++ debian/control 2013-09-11 13:52:00 +0000
4@@ -50,7 +50,7 @@
5 checkbox-cli | checkbox-gtk,
6 curl,
7 ethtool,
8- fwts,
9+ fwts (>=0.26.08-0.ubuntu1),
10 git-core,
11 glmark2,
12 glmark2-es2,

Subscribers

People subscribed via source and target branches