Merge lp:~roadmr/checkbox/fix-memory-compare into lp:checkbox

Proposed by Daniel Manrique
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 1845
Merged at revision: 1845
Proposed branch: lp:~roadmr/checkbox/fix-memory-compare
Merge into: lp:checkbox
Diff against target: 24 lines (+3/-1)
2 files modified
debian/changelog (+2/-0)
scripts/memory_compare (+1/-1)
To merge this branch: bzr merge lp:~roadmr/checkbox/fix-memory-compare
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+139281@code.launchpad.net

Commit message

An easy fix for an accumulator expression causing memory_compare to give strange negative-difference results.

Description of the change

An easy fix for an accumulator expression causing memory_compare to give strange negative-difference results.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-12-07 17:00:38 +0000
3+++ debian/changelog 2012-12-11 18:17:21 +0000
4@@ -4,6 +4,8 @@
5 * New version 0.15 for Raring Ringtail development.
6 * Added environ key to poweroff and reboot jobs so they create logs in the
7 expected location (LP: #1085833)
8+ * scripts/memory_compare: Fixed accumulator expression to give good results
9+ (LP: #1089046)
10
11 [ Brendan Donegan ]
12 * Change forward-slashes to asterisks in the filename of a connection, since
13
14=== modified file 'scripts/memory_compare'
15--- scripts/memory_compare 2012-07-11 14:43:14 +0000
16+++ scripts/memory_compare 2012-12-11 18:17:21 +0000
17@@ -17,7 +17,7 @@
18
19 if form and "IMM" in form:
20 try:
21- self.total_size = int(getattr(device, "size", 0))
22+ self.total_size += int(getattr(device, "size", 0))
23 except ValueError:
24 pass
25

Subscribers

People subscribed via source and target branches