Merge lp:~roadmr/checkbox/fix-media-keys into lp:checkbox
Proposed by
Daniel Manrique
Status: | Merged |
---|---|
Merged at revision: | 1316 |
Proposed branch: | lp:~roadmr/checkbox/fix-media-keys |
Merge into: | lp:checkbox |
Diff against target: |
27 lines (+6/-2) 2 files modified
debian/changelog (+5/-1) jobs/keys.txt.in (+1/-1) |
To merge this branch: | bzr merge lp:~roadmr/checkbox/fix-media-keys |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeff Lane | Approve | ||
Review via email: mp+97308@code.launchpad.net |
Description of the change
Fixes borked syntax preventing media-keys test from running.
To post a comment you must log in.
Looks good. Tested and the test does indeed run and indicate it passed.
The only thing I noticed is that while the instructions say that Yes will be selected if it passes, this did not happen and I had to manually select Yes, otherwise checkbox-qt asked me if I really wanted to skip the test. (I had to skip the Stop button test because my test machine doesn't have Stop).
That's a separate issue though and I'll open a bug for that shortly.