Merge lp:~roadmr/checkbox/fix-media-keys into lp:checkbox

Proposed by Daniel Manrique
Status: Merged
Merged at revision: 1316
Proposed branch: lp:~roadmr/checkbox/fix-media-keys
Merge into: lp:checkbox
Diff against target: 27 lines (+6/-2)
2 files modified
debian/changelog (+5/-1)
jobs/keys.txt.in (+1/-1)
To merge this branch: bzr merge lp:~roadmr/checkbox/fix-media-keys
Reviewer Review Type Date Requested Status
Jeff Lane  Approve
Review via email: mp+97308@code.launchpad.net

Description of the change

Fixes borked syntax preventing media-keys test from running.

To post a comment you must log in.
Revision history for this message
Jeff Lane  (bladernr) wrote :

Looks good. Tested and the test does indeed run and indicate it passed.

The only thing I noticed is that while the instructions say that Yes will be selected if it passes, this did not happen and I had to manually select Yes, otherwise checkbox-qt asked me if I really wanted to skip the test. (I had to skip the Stop button test because my test machine doesn't have Stop).

That's a separate issue though and I'll open a bug for that shortly.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-03-12 21:27:15 +0000
3+++ debian/changelog 2012-03-13 21:37:18 +0000
4@@ -15,7 +15,11 @@
5 [Marc Tardif]
6 * Linted qt_interface which had a few syntax errors (LP: #949957)
7
8- -- Daniel Manrique <roadmr@ubuntu.com> Mon, 12 Mar 2012 16:40:00 -0400
9+ [Daniel Manrique]
10+ * jobs/keys.txt.in: Fix definition for keys/media-keys test which failed to
11+ run (LP: #954480)
12+
13+ -- Daniel Manrique <roadmr@ubuntu.com> Tue, 13 Mar 2012 17:34:36 -0400
14
15 checkbox (0.13.4) precise; urgency=low
16
17
18=== modified file 'jobs/keys.txt.in'
19--- jobs/keys.txt.in 2012-01-23 04:10:33 +0000
20+++ jobs/keys.txt.in 2012-03-13 21:37:18 +0000
21@@ -78,5 +78,5 @@
22 1. Click test to open a window on which to test the media control keys.
23 2. If all the keys work, the test will be marked as passed.
24 3. If your computer has no media control keys, Skip this test.
25- VERIFICATION:
26+ VERIFICATION:
27 Do the keys work as expected?

Subscribers

People subscribed via source and target branches