Merge lp:~roadmr/checkbox/fix-lintian-warnings into lp:checkbox

Proposed by Daniel Manrique
Status: Merged
Merged at revision: 1139
Proposed branch: lp:~roadmr/checkbox/fix-lintian-warnings
Merge into: lp:checkbox
Diff against target: 92 lines (+14/-9)
3 files modified
debian/changelog (+5/-1)
debian/control (+8/-8)
debian/source/format (+1/-0)
To merge this branch: bzr merge lp:~roadmr/checkbox/fix-lintian-warnings
Reviewer Review Type Date Requested Status
Marc Tardif (community) Approve
Review via email: mp+84683@code.launchpad.net

Description of the change

Just some updates to the debian control files to take care of an old bug. These are just lintian warnings, things work fine even without these changes, and I'm certainly not an expert in Debian packaging, so feel free to comment on this.

I particularly dislike having e.g. checkbox-gtk with this depends:

checkbox (>= ${source:Version})

as it can potentially couple, say, checkbox 0.13 with checkbox-gtk 0.12, but this new format is required for the thing to be "binNMUable" (I'll spare you the trouble of hunting down useful information on that: http://wiki.debian.org/binNMU)

As I said before, these are all just warnings and can potentially be ignored.

To post a comment you must log in.
Revision history for this message
Marc Tardif (cr3) wrote :

Lintian is pedantic but pedantic is not always right. This applies to debian packaging but Python as well, like this also throws a warning by pylint:

try:
    import xml.etree.cElementTree as etree
except ImportError:
    import cElementTree as etree

# redefinition of unused 'etree'

As long as it doesn't hurt (too much), I'm alright with changes like (>= ${source:Version}).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-12-02 22:04:21 +0000
3+++ debian/changelog 2011-12-06 21:38:10 +0000
4@@ -13,8 +13,12 @@
5 [Marc Tardif]
6 * Refactored install script to be agnostic of variant name.
7 * Using title defined in user_interface plugin in GTK interface.
8+
9+ [Daniel Manrique]
10+ * Update control files under debian/ to eliminate (most) lintian warnings
11+ (LP: #352986)
12
13- -- Daniel Manrique <daniel.manrique@canonical.com> Thu, 01 Dec 2011 09:48:58 -0500
14+ -- Daniel Manrique <daniel.manrique@canonical.com> Tue, 06 Dec 2011 16:31:47 -0500
15
16 checkbox (0.13) precise; urgency=low
17
18
19=== modified file 'debian/control'
20--- debian/control 2011-09-09 12:26:14 +0000
21+++ debian/control 2011-12-06 21:38:10 +0000
22@@ -1,9 +1,9 @@
23 Source: checkbox
24 Section: utils
25 Priority: optional
26-XSBC-Original-Maintainer: Marc Tardif <marc@ubuntu.com>
27+Uploaders: Marc Tardif <marc@ubuntu.com>
28 Maintainer: Ubuntu Core Developers <ubuntu-devel-discuss@lists.ubuntu.com>
29-Standards-Version: 3.7.3
30+Standards-Version: 3.9.2
31 X-Python-Version: >= 2.6
32 Build-Depends: debhelper (>= 7.0.50~), dh-translations, python (>= 2.6.6-3~), po-debconf, python-distutils-extra
33 Vcs-Bzr: https://code.launchpad.net/~hardware-certification/checkbox/trunk
34@@ -25,7 +25,7 @@
35 Architecture: all
36 Replaces: hwtest-cli (<< 0.1-0ubuntu12)
37 Provides: hwtest-cli
38-Depends: checkbox (= ${source:Version})
39+Depends: checkbox (>= ${source:Version}), ${misc:Depends}
40 Conflicts: hwtest-cli (<< 0.1-0ubuntu12)
41 Description: Command line interface for checkbox
42 This project provides an extensible interface for system testing. The
43@@ -35,7 +35,7 @@
44
45 Package: checkbox-urwid
46 Architecture: all
47-Depends: checkbox (= ${source:Version}), python-urwid
48+Depends: checkbox (>= ${source:Version}), python-urwid, ${misc:Depends}
49 Description: Urwid interface for checkbox
50 This project provides an extensible interface for system testing. The
51 results can then be sent to Launchpad.
52@@ -48,7 +48,7 @@
53 Architecture: all
54 Replaces: hwtest-gtk (<< 0.1-0ubuntu12)
55 Provides: hwtest-gtk
56-Depends: checkbox (= ${source:Version}), gksu, python-gobject (>= 2.28), gir1.2-gtk-3.0
57+Depends: checkbox (>= ${source:Version}), gksu, python-gobject (>= 2.28), gir1.2-gtk-3.0, ${misc:Depends}
58 Conflicts: hwtest-gtk (<< 0.1-0ubuntu12)
59 Description: GTK interface for checkbox
60 This project provides an extensible interface for system testing. The
61@@ -59,13 +59,13 @@
62 Package: hwtest
63 Section: python
64 Architecture: all
65-Depends: checkbox
66+Depends: checkbox, ${misc:Depends}
67 Description: Transitional package to checkbox
68 This package is a transitional package for renaming hwtest to checkbox.
69
70 Package: hwtest-cli
71 Architecture: all
72-Depends: checkbox-cli
73+Depends: checkbox-cli, ${misc:Depends}
74 Description: Transitional package to checkbox-cli
75 This package is a transitional package for renaming hwtest-cli to
76 checkbox-cli.
77@@ -73,7 +73,7 @@
78 Package: hwtest-gtk
79 Section: gnome
80 Architecture: all
81-Depends: checkbox-gtk
82+Depends: checkbox-gtk, ${misc:Depends}
83 Description: Transitional package to checkbox-gtk
84 This package is a transitional package for renaming hwtest-gtk to
85 checkbox-gtk.
86
87=== added directory 'debian/source'
88=== added file 'debian/source/format'
89--- debian/source/format 1970-01-01 00:00:00 +0000
90+++ debian/source/format 2011-12-06 21:38:10 +0000
91@@ -0,0 +1,1 @@
92+3.0 (native)

Subscribers

People subscribed via source and target branches