Checkbox

Merge lp:~roadmr/checkbox/971181 into lp:checkbox

  1. 971181
  2. Merge into trunk
Proposed by Daniel Manrique
Status: Merged
Merged at revision: 1358
Proposed branch: lp:~roadmr/checkbox/971181
Merge into: lp:checkbox
Diff against target: 40 lines (+3/-3)
2 files modified
debian/changelog (+3/-0)
jobs/optical.txt.in (+0/-3)
To merge this branch: bzr merge lp:~roadmr/checkbox/971181
Reviewer Review Type Date Requested Status
Jeff Lane  Approve
Review via email: mp+101642@code.launchpad.net

Description of the change

Implements a proposed workaround for bug 971181 which consists of removing the "press Next to continue" instruction (which is wrong, as doing that assumes the user wants to skip the test).

Rather, we leave things "nebulous" as to what to do, but since the user should be accustomed to pressing "yes" or "no" on each test, this should be less confusing. Automatically-verified tests should focus the correct answer in behalf of the user, so just clicking on that (or, I think, pressing Enter) should do the right thing (tm).

To post a comment you must log in.
Revision history for this message
Jeff Lane  (bladernr) wrote :

Looks good. Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-04-11 07:12:00 +0000
3+++ debian/changelog 2012-04-11 20:15:26 +0000
4@@ -17,6 +17,9 @@
5 * [FEATURE] Modified stress jobs so that they are all automated per decision
6 made during the cert sprint.
7
8+ [Daniel Manrique]
9+ * jobs/optical.txt.in: Change test descriptions to avoid confusing
10+ instruction to press the "Next" button (which is incorrect). (LP: #971181)
11
12 -- Jeff Lane <jeff@ubuntu.com> Mon, 09 Apr 2012 17:12:51 -0400
13
14
15=== modified file 'jobs/optical.txt.in'
16--- jobs/optical.txt.in 2012-03-19 08:22:57 +0000
17+++ jobs/optical.txt.in 2012-04-11 20:15:26 +0000
18@@ -20,7 +20,6 @@
19 1. Insert appropriate non-blank media into your optical drive(s). Movie and Audio Disks may not work. Self-created data disks have the greatest chance of working.
20 2. If a file browser window opens, you can safely close or ignore that window.
21 3. Click "Test" to being the test.
22- 4. When the test completes, proceed by clicking "Next"
23 VERIFICATION:
24 This test should automatically select "Yes" if it passes, "No" if it fails.
25
26@@ -47,7 +46,6 @@
27 1. Enter a blank CD-R into your drive
28 2. Click "Test" to begin.
29 3. When the CD tray ejects the media after burning, close it (DO NOT remove the disk, it is needed for the second portion of the test). Note, you must close the drive within 10 seconds or the test will time out.
30- 4. When the test completes, proceed by clicking "Next"
31 VERIFICATION:
32 This test should automatically select "Yes" if it passes, "No" if it fails.
33
34@@ -84,7 +82,6 @@
35 1. Enter a blank DVD-R into your drive
36 2. Click "Test" to begin.
37 3. When the CD tray ejects the media after burning, close it (DO NOT remove the disk, it is needed for the second portion of the test). Note, you must close the drive within 10 seconds or the test will time out.
38- 4. When the test completes, proceed by clicking "Next"
39 VERIFICATION:
40 This test should automatically select "Yes" if it passes, "No" if it fails.
41

Subscribers

People subscribed via source and target branches