Merge lp:~roadmr/checkbox/923836 into lp:checkbox
Proposed by
Daniel Manrique
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 1205 | ||||
Proposed branch: | lp:~roadmr/checkbox/923836 | ||||
Merge into: | lp:checkbox | ||||
Diff against target: |
44 lines (+6/-4) 2 files modified
debian/changelog (+3/-1) scripts/create_connection (+3/-3) |
||||
To merge this branch: | bzr merge lp:~roadmr/checkbox/923836 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Marc Tardif (community) | Approve | ||
Review via email: mp+90774@code.launchpad.net |
Description of the change
This branch updates the command we use to obtain the wireless interface's MAC address, to make it less vulnerable to context changes. Also, if the command fails to get the MAC address, extra logic avoids generating an interface file with an empty mac-address field. Our resident Network Manager expert (cyphermox) is pretty certain that the mac-address field is not even necessary for things to work correctly, which I validated experimentally, so this should still work in all cases.
To post a comment you must log in.
The *changes* look good, merging.