Merge lp:~roadmr/checkbox/852204 into lp:checkbox

Proposed by Daniel Manrique
Status: Merged
Merged at revision: 1050
Proposed branch: lp:~roadmr/checkbox/852204
Merge into: lp:checkbox
Diff against target: 42 lines (+8/-2)
3 files modified
debian/changelog (+5/-2)
plugins/intro_prompt.py (+2/-0)
plugins/suites_prompt.py (+1/-0)
To merge this branch: bzr merge lp:~roadmr/checkbox/852204
Reviewer Review Type Date Requested Status
Brendan Donegan (community) Approve
Marc Tardif (community) Approve
Review via email: mp+76094@code.launchpad.net

Description of the change

Welcome and test selection screens failed because of a missing _recover attribute that was removed in revision 1041. I basically just put them back with a (hopefully) sensible default value.

Even though I tested that things work fine with this change (i.e. if I select "No" to "Restore previous run?" then the store/0/ directory gets cleared out) I'd appreciate review on this, to ensure that this (trivial) change is sane.

To post a comment you must log in.
Revision history for this message
Marc Tardif (cr3) wrote :

The change looks like it "recovers" the same behavior as before, looks good!

review: Approve
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

My testing shows it works well now. I've no objections to this merge request.

review: Approve
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Heh, I missed cr3's approve there.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-09-15 14:35:13 +0000
3+++ debian/changelog 2011-09-19 20:09:49 +0000
4@@ -1,8 +1,11 @@
5 checkbox (0.12.8) oneiric; urgency=low
6
7- * Incremented version
8+ [Daniel Manrique]
9+ * Restored _recover attribute, re-enabling welcome and test selection
10+ screens (LP: #852204)
11+ * Remove memory/test from the Ubuntu Friendly whitelist (LP: #853799)
12
13- -- Daniel Manrique <daniel.manrique@canonical.com> Thu, 15 Sep 2011 10:34:02 -0400
14+ -- Daniel Manrique <daniel.manrique@canonical.com> Mon, 19 Sep 2011 15:31:24 -0400
15
16 checkbox (0.12.7) oneiric; urgency=low
17
18
19=== modified file 'plugins/intro_prompt.py'
20--- plugins/intro_prompt.py 2011-09-12 13:52:18 +0000
21+++ plugins/intro_prompt.py 2011-09-19 20:09:49 +0000
22@@ -27,6 +27,8 @@
23 def register(self, manager):
24 super(IntroPrompt, self).register(manager)
25
26+ self._recover = False
27+
28 self._manager.reactor.call_on("begin-recover", self.begin_recover)
29
30 # Introduction should be prompted last
31
32=== modified file 'plugins/suites_prompt.py'
33--- plugins/suites_prompt.py 2011-09-12 13:52:18 +0000
34+++ plugins/suites_prompt.py 2011-09-19 20:09:49 +0000
35@@ -43,6 +43,7 @@
36 self._depends = {}
37 self._jobs = {}
38 self._persist = None
39+ self._recover = False
40
41 for (rt, rh) in [
42 ("begin-persist", self.begin_persist),

Subscribers

People subscribed via source and target branches