Checkbox

Merge lp:~roadmr/checkbox/833696 into lp:checkbox

  1. 833696
  2. Merge into trunk
Proposed by Daniel Manrique
Status: Merged
Merge reported by: Brendan Donegan
Merged at revision: not available
Proposed branch: lp:~roadmr/checkbox/833696
Merge into: lp:checkbox
Diff against target: 32 lines (+4/-2)
2 files modified
debian/changelog (+3/-1)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~roadmr/checkbox/833696
Reviewer Review Type Date Requested Status
Brendan Donegan (community) Approve
Review via email: mp+73093@code.launchpad.net

Description of the change

With this change, the base checkbox package (not any of the UI packages) will be built on a per-architecture basis, mainly so that threaded_memtest and clocktest get built for the correct architecture, because they could potentially have trouble on amd64 systems (unless ia32-libs is installed).

It's a small change but I'd appreciate feedback due to the possible implications of having arch-specific builds.

Note that threaded_memtest will now be built 64-bit for servers, so any bugs involving that scenario might also be affected by this.

To post a comment you must log in.
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

The alternative is that clocktest always fails. I don't see any reason why this should be a problem.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-08-25 15:05:30 +0000
3+++ debian/changelog 2011-08-26 19:39:23 +0000
4@@ -8,12 +8,14 @@
5 * Changed name of apt-get test to reflect the suite it's in.
6 * Fixed typos in job definitions that caused them to not be run.
7 * Added missing description to info/hdparm test (LP: #832351)
8+ * Changed architecture from all to any for checkbox base, to build
9+ architecture-specific binaries (LP: #833696)
10
11 [Jeff Lane]
12 * Added new USB storage transfer test
13 * Re-worked and added automated audio test
14
15- -- Jeff Lane <jeff@ubuntu.com> Thu, 25 Aug 2011 11:03:29 -0400
16+ -- Daniel Manrique <daniel.manrique@canonical.com> Fri, 26 Aug 2011 15:27:41 -0400
17
18 checkbox (0.12.4) oneiric; urgency=low
19
20
21=== modified file 'debian/control'
22--- debian/control 2011-08-25 15:05:30 +0000
23+++ debian/control 2011-08-26 19:39:23 +0000
24@@ -10,7 +10,7 @@
25
26 Package: checkbox
27 Section: python
28-Architecture: all
29+Architecture: any
30 Replaces: hwtest (<< 0.1-0ubuntu12)
31 Provides: hwtest
32 Depends: ${misc:Depends}, ${python:Depends}, debconf, udev

Subscribers

People subscribed via source and target branches