Merge lp:~roadmr/checkbox/776734 into lp:checkbox
Proposed by
Daniel Manrique
Status: | Merged |
---|---|
Merged at revision: | 914 |
Proposed branch: | lp:~roadmr/checkbox/776734 |
Merge into: | lp:checkbox |
Diff against target: |
34 lines (+7/-2) 2 files modified
debian/changelog (+6/-1) gtk/checkbox-gtk.ui (+1/-1) |
To merge this branch: | bzr merge lp:~roadmr/checkbox/776734 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Marc Tardif (community) | Approve | ||
Review via email: mp+61836@code.launchpad.net |
Description of the change
Gtk containers are supposed to resize to automatically fit their child widgets. However, the .ui file for checkbox specified a fixed width_request of 450px for the main window, and it didn't grow to accomodate all its widgets if they happened to add up to be larger than 450px. This wasn't obvious because the default window size contains all required buttons with text in english, which is what a vast majority of checkbox users use.
This fix asks the window to use a width_request of -1 (meaning "use the widget's natural size"), and in practice this makes it so that, when the additional buttons are shown, the window grows horizontally to accomodate them.
To post a comment you must log in.
Awesome, thanks!