Merge lp:~roadmr/checkbox/776734 into lp:checkbox

Proposed by Daniel Manrique
Status: Merged
Merged at revision: 914
Proposed branch: lp:~roadmr/checkbox/776734
Merge into: lp:checkbox
Diff against target: 34 lines (+7/-2)
2 files modified
debian/changelog (+6/-1)
gtk/checkbox-gtk.ui (+1/-1)
To merge this branch: bzr merge lp:~roadmr/checkbox/776734
Reviewer Review Type Date Requested Status
Marc Tardif (community) Approve
Review via email: mp+61836@code.launchpad.net

Description of the change

Gtk containers are supposed to resize to automatically fit their child widgets. However, the .ui file for checkbox specified a fixed width_request of 450px for the main window, and it didn't grow to accomodate all its widgets if they happened to add up to be larger than 450px. This wasn't obvious because the default window size contains all required buttons with text in english, which is what a vast majority of checkbox users use.

This fix asks the window to use a width_request of -1 (meaning "use the widget's natural size"), and in practice this makes it so that, when the additional buttons are shown, the window grows horizontally to accomodate them.

To post a comment you must log in.
Revision history for this message
Marc Tardif (cr3) wrote :

Awesome, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-05-17 13:48:20 +0000
3+++ debian/changelog 2011-05-20 21:41:14 +0000
4@@ -1,11 +1,16 @@
5 checkbox (0.12) oneiric; urgency=low
6
7+ [ Marc Tardif ]
8 * Removed dead pixel test.
9
10 [Bilal Akhtar]
11 * Port checkbox to Gtk3/PyGI (LP: #783822)
12
13- -- Marc Tardif <marc@ubuntu.com> Tue, 17 May 2011 09:48:07 -0400
14+ [ Daniel Manrique ]
15+ * Fix GUI definition file so main window uses "natural request", growing
16+ when child widgets require so (LP: #776734)
17+
18+ -- Daniel Manrique <daniel.manrique@canonical.com> Fri, 20 May 2011 17:21:59 -0400
19
20 checkbox (0.11.4) natty; urgency=low
21
22
23=== modified file 'gtk/checkbox-gtk.ui'
24--- gtk/checkbox-gtk.ui 2011-02-18 15:19:51 +0000
25+++ gtk/checkbox-gtk.ui 2011-05-20 21:41:14 +0000
26@@ -4,7 +4,7 @@
27 <!-- interface-requires hyper_text_view 1.0 -->
28 <!-- interface-naming-policy toplevel-contextual -->
29 <object class="GtkDialog" id="dialog_main">
30- <property name="width_request">450</property>
31+ <property name="width_request">-1</property>
32 <property name="height_request">400</property>
33 <property name="visible">True</property>
34 <property name="title" translatable="yes">System Testing</property>

Subscribers

People subscribed via source and target branches