lp:~roadmr/checkbox/1457970-2.7-decode

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 3809

Zygmunt Krynicki (community): Approve on 2015-05-23

Diff: 62 lines (+30/-4)

3 files modified

checkbox-support/checkbox_support/parsers/submission.py (+7/-1)
checkbox-support/checkbox_support/parsers/tests/fixtures/submission_info_non_ascii.xml (+15/-0)
checkbox-support/checkbox_support/parsers/tests/test_submission.py (+8/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1457970: UnicodeEncodeError when run under Python 2.7

High

Fix Released

Link a bug report

Related blueprints

3808. By Daniel Manrique on 2015-05-22

checkbox-support:parsers:submission: Don't try to decode unicodes under Python 2.7.

This was causing problems when using the submission parser under Python 2.7 (HEXR) in cases
where the submission xml contains accented characters (it would have happened with any non-ascii character).

Includes test and data fixture that triggers the problem.

Fixes: https://bugs.launchpad.net/checkbox-support/+bug/1457970

3807. By Daniel Manrique on 2015-05-22

checkbox-support:parsers: Use filenames instead of file-likes for submission parser testing.

This caused problems with a test fixture which included strange non-ascii (but xml-valid) characters.
Since etree.parse was being passed a file-like object, it was unhappy with the encoding/decoding and
was giving UnicodeEncodeErrors.

etree.parse supports passing a filename, in which case it handles opening and encoding/decoding the file and is happy.

This affected only testing under Python 2.7. The tests were verified under both 2.7 and 3.4 and they worked OK.

3806. By Daniel Manrique on 2015-05-21

"providers:checkbox: Update dell_bto_attachment job with user: root
 [r=sylvain-pineau][bug=1457613][author=roadmr]"

3805. By Daniel Manrique on 2015-05-21

"providers:checkbox: Fix wrong usage of recovery_info script in some info jobs [r=sylvain-pineau,zyga][bug=1457505][author=roadmr]"

3804. By Zygmunt Krynicki on 2015-05-21

"automatic merge of lp:~zyga/checkbox/image-info/ by tarmac [r=shawn111,zyga,roadmr][bug=][author=zyga]"

3803. By Launchpad Translations on behalf of checkbox-dev on 2015-05-21

Launchpad automatic translations update.

3802. By Po-Hsu Lin on 2015-05-20

"automatic merge of lp:~cypressyew/checkbox/bt-a2dp-fix/ by tarmac [r=zyga][bug=1326746][author=cypressyew]"

3801. By Taihsiang Ho on 2015-05-20

"automatic merge of lp:~taihsiangho/checkbox/checkbox-translation-zh_TW-150519/ by tarmac [r=zyga][bug=][author=taihsiangho]"

3800. By Taihsiang Ho on 2015-05-20

"automatic merge of lp:~taihsiangho/checkbox/checkbox-translation-zh_TW-150519_pot/ by tarmac [r=zyga][bug=][author=taihsiangho]"

3799. By Po-Hsu Lin on 2015-05-20

"automatic merge of lp:~cypressyew/checkbox/fix-tb-generator/ by tarmac [r=zyga][bug=1456907][author=cypressyew]"