Merge lp:~roadmr/checkbox/1357338-hexr-share into lp:checkbox
Status: | Merged |
---|---|
Approved by: | Zygmunt Krynicki |
Approved revision: | 3200 |
Merged at revision: | 3206 |
Proposed branch: | lp:~roadmr/checkbox/1357338-hexr-share |
Merge into: | lp:checkbox |
Diff against target: |
88 lines (+51/-0) 2 files modified
checkbox-ng/checkbox_ng/certification.py (+31/-0) checkbox-ng/checkbox_ng/test_certification.py (+20/-0) |
To merge this branch: | bzr merge lp:~roadmr/checkbox/1357338-hexr-share |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zygmunt Krynicki (community) | Approve | ||
Review via email: mp+231459@code.launchpad.net |
Commit message
checkbox-
If the option string to the transport contains submit_to_hexr=1,
then send the X_SHARE_WITH_HEXR http header when uploading.
(LP: #1357338)
Description of the change
checkbox-
If the option string to the transport contains submit_to_hexr=1,
then send the X_SHARE_WITH_HEXR http header when uploading.
(LP: #1357338)
the GUI and dbus are propagating the tick mark's setting properly into a transport option; the problem is that the certification transport (part of the plainbox library) wasn't actually translating that option into the HTTP header required for hexr to slurp the submission.
Just two minor comments, have a look