Merge lp:~roadmr/checkbox/1348539-screenshot-jobs into lp:checkbox

Proposed by Daniel Manrique
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 3142
Merged at revision: 3142
Proposed branch: lp:~roadmr/checkbox/1348539-screenshot-jobs
Merge into: lp:checkbox
Diff against target: 24 lines (+17/-0)
1 file modified
providers/plainbox-provider-checkbox/jobs/graphics.txt.in (+17/-0)
To merge this branch: bzr merge lp:~roadmr/checkbox/1348539-screenshot-jobs
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+228350@code.launchpad.net

Commit message

providers:checkbox: Add a simple screen capture job with matching attachment job.

Job uses gnome-screenshot to capture, then a simple base64 encoding to attach the screenshot.

Description of the change

providers:checkbox: Add a simple screen capture job with matching attachment job.

Job uses gnome-screenshot to capture, then a simple base64 encoding to attach the screenshot.

Dependencies are properly setup, so one can include only the screen-capture-internal.png job and the actual screenshot command will automatically run.

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'providers/plainbox-provider-checkbox/jobs/graphics.txt.in'
2--- providers/plainbox-provider-checkbox/jobs/graphics.txt.in 2014-07-21 15:33:35 +0000
3+++ providers/plainbox-provider-checkbox/jobs/graphics.txt.in 2014-07-25 17:15:21 +0000
4@@ -533,3 +533,20 @@
5 _description: Attaches the screenshot captured in graphics/screenshot_opencv_validation.
6 _summary: Attach the screenshot captured for the automatically validated screenshot test
7
8+plugin: shell
9+id: graphics/screen-capture-internal
10+_summary: Obtains a simple screen capture
11+estimated_duration: 1.0
12+requires: package.name == 'gnome-screenshot'
13+command: gnome-screenshot --file ${PLAINBOX_SESSION_SHARE}/screen-capture.png
14+_description: Obtains a simple screen capture using gnome-screenshot if present
15+
16+plugin: attachment
17+id: screen-capture-internal.png
18+_summary: Attaches a simple screen capture
19+estimated_duration: 1.0
20+depends: graphics/screen-capture-internal
21+command: [ -f ${PLAINBOX_SESSION_SHARE}/screen-capture.png ] && base64 ${PLAINBOX_SESSION_SHARE}/screen-capture.png
22+_description: Attaches the simple screen capture file
23+
24+

Subscribers

People subscribed via source and target branches