Merge lp:~roadmr/checkbox/1268576-highest-resolution-test into lp:checkbox

Proposed by Daniel Manrique
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 2594
Merged at revision: 2596
Proposed branch: lp:~roadmr/checkbox/1268576-highest-resolution-test
Merge into: lp:checkbox
Diff against target: 50 lines (+18/-0)
3 files modified
checkbox-old/data/whitelists/client-cert.whitelist (+1/-0)
checkbox-old/data/whitelists/client-selftest.whitelist (+1/-0)
checkbox-old/jobs/graphics.txt.in (+16/-0)
To merge this branch: bzr merge lp:~roadmr/checkbox/1268576-highest-resolution-test
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+201497@code.launchpad.net

Commit message

A user-verified test to confirm the maximum resolution seen by xrandr is indeed the maximum supported by the hardware.

It does not explicitly test that this resolution is good because the cycle-resolutions test will cycle through this one and have it tested.

Description of the change

A user-verified test to confirm the maximum resolution seen by xrandr is indeed the maximum supported by the hardware.

I'm not explicitly confirming that this resolution looks good (where "good" means pixel-accurate, not "usable") because the cycle-resolutions test will cycle through this one and have it tested.

I'm also using the horrible zenity method of showing information, because the qmlscene one only shows the currently active resolution and not the maximum supported one.

To post a comment you must log in.
2594. By Daniel Manrique

added max resolution test to relevant whitelists

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1, thanks for supporting dual head testing :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox-old/data/whitelists/client-cert.whitelist'
2--- checkbox-old/data/whitelists/client-cert.whitelist 2013-12-17 21:49:16 +0000
3+++ checkbox-old/data/whitelists/client-cert.whitelist 2014-01-13 20:26:23 +0000
4@@ -79,6 +79,7 @@
5 graphics/rotation
6 graphics/display
7 graphics/minimum_resolution
8+graphics/maximum_resolution
9 graphics/xorg-failsafe
10 graphics/xorg-process
11 graphics/VESA_drivers_not_in_use
12
13=== modified file 'checkbox-old/data/whitelists/client-selftest.whitelist'
14--- checkbox-old/data/whitelists/client-selftest.whitelist 2013-12-17 21:49:16 +0000
15+++ checkbox-old/data/whitelists/client-selftest.whitelist 2014-01-13 20:26:23 +0000
16@@ -76,6 +76,7 @@
17 graphics/rotation
18 graphics/display
19 graphics/minimum_resolution
20+graphics/maximum_resolution
21 graphics/xorg-failsafe
22 graphics/xorg-process
23 graphics/VESA_drivers_not_in_use
24
25=== modified file 'checkbox-old/jobs/graphics.txt.in'
26--- checkbox-old/jobs/graphics.txt.in 2013-12-18 09:24:56 +0000
27+++ checkbox-old/jobs/graphics.txt.in 2014-01-13 20:26:23 +0000
28@@ -85,6 +85,22 @@
29 .
30 https://help.ubuntu.com/community/Installation/SystemRequirements
31
32+plugin: user-verify
33+name: graphics/maximum_resolution
34+requires:
35+ device.category == 'VIDEO'
36+ package.name == 'zenity'
37+command: zenity --info --text "Maximum resolution: $(xrandr -q |grep -A 1 "connected\( primary\)* [0-9]" |tail -1 |awk '{print $1}')"
38+estimated_duration: 10
39+_description:
40+ PURPOSE:
41+ This test will verify the display is operating at its maximum supported resolution
42+ STEPS:
43+ 1. Consult the system's specifications and locate the screen's maximum supported resolution.
44+ 2. Click on Test to display the maximum resolution that can be used by Ubuntu on the current display.
45+ VERIFICATION:
46+ Is this the display's maximum resolution?
47+
48 name: graphics/modes
49 plugin: shell
50 command: graphics_modes_info

Subscribers

People subscribed via source and target branches