lp:~roadmr/checkbox/1214123-fix-udevadm-submission-parsing-armhf

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:checkbox at revision 2309

Brendan Donegan (community): Approve on 2013-08-20

Diff: 11170 lines (+11110/-1)

6 files modified

checkbox-old/checkbox/parsers/submission.py (+4/-1)
checkbox-old/checkbox/parsers/tests/fixtures/submission_udev_armhf.xml (+4247/-0)
checkbox-old/checkbox/parsers/tests/test_submission.py (+9/-0)
checkbox-old/checkbox/parsers/tests/test_udevadm.py (+22/-0)
checkbox-old/checkbox/parsers/tests/udevadm_data/CALXEDA_HIGHBANK.txt (+6826/-0)
checkbox-old/debian/changelog (+2/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1214123: SubmissionParser doesn't understand armhf architecture

High

Fix Released

Link a bug report

Related blueprints

2312. By Daniel Manrique on 2013-08-19

checkbox:parsers:submission: Fixed architecture matching which was causing udevadm processing to fail on armhf. (LP: #1214123)

A test using the previously-added data file is included.

This was only tested with amd64, i386 and armhf architectures.

2311. By Daniel Manrique on 2013-08-19

Added submission for armhf for udev/submission parser testing

2310. By Daniel Manrique on 2013-08-19

checkbox:parsers:udevadm: Added udevadm parsing tests for calxeda highbank, an armhf-based, server-oriented system with very few devices

2309. By Daniel Manrique on 2013-08-19

Added Calxeda Highbank ARM-based server udev data

2308. By Daniel Manrique on 2013-08-19

"At Andew's request, renamed ExportSession to ExportSessionToFile, keeping the same functionality, and added a new ExportSession that returns the exported data (xml, json, whatever) as a string over DBus.

This is easier for a UI to display since it doesn't have to decide on a temporary filename, it just receives a big string.

Traditionally the xml reports are 1 MB and larger, but the use case for this is to display a user-viewable report on a qml component using e.g. webkit, so maybe we can come up with an exporter that produces a simplified html representation of the session. Something like what old checkbox-ihv's save report functionality produces. I think those are not so big (even including inlined resources).
 [r=zkrynicki][bug=][author=roadmr]"

2307. By Daniel Manrique on 2013-08-18

"Formalizes and describes origin behavior, both for jobs originating in a file (with proper line numbers) and jobs taken from a stream (such as those generated from a localjob).

A few extra base behaviors for Origin were required; these are also properly tested now. [r=][bug=][author=roadmr]"

2306. By Zygmunt Krynicki on 2013-08-16

"automatic merge by tarmac [r=roadmr][bug=][author=zkrynicki]"

2305. By Daniel Manrique on 2013-08-16

"Fixes the parser which was generating incorrect data for network devices.

The problem is caused by a cleaned-up path for devices causing incorrect lookups of product and device ids (it's looking at the *parent* device's identifiers). The cleaned-up path is required by some external applications (such as udev_resource script), so rather than simply removing the offending commit (and generating the "dirty" paths), the fix was to use the full device paths for device matching and id determination purposes (all this is internal to UdevadmParser), while maintaining the filtering for the public path attribute.

The udevadmparser tests were fleshed out to properly identify this behavior, so we can better ensure the device information we generate is accurate. [r=zkrynicki][bug=1211521][author=roadmr]"

2304. By Daniel Manrique on 2013-08-15

"Added a couple of checks so that tests looking for video files in $CHECKBOX_SHARE fail gracefully if the files don't exist. [r=zkrynicki][bug=1202946][author=roadmr]"

2303. By Daniel Manrique on 2013-08-15

"Adds a __version__ attribute to the checkbox.parsers.submission module, at the request of the PES Infrastructure team, to be used to determine when to reparse a submission. [r=zkrynicki][bug=1211825][author=roadmr]"