Merge lp:~roadmr/checkbox/1201126-unlocalized-audio-test into lp:checkbox

[Daniel Manrique]

Ensures that pactl commands are run on a properly unlocalized environment. Code was setting LANG to "C", but that seems to not reset LANGUAGE which is still honored by pactl. Setting LANG to POSIX instead produces the desired behavior.

Ensures that pactl commands are run on a properly unlocalized environment. Code was setting LANG to "C", but that seems to not reset LANGUAGE which is still honored by pactl. Setting LANG to POSIX instead produces the desired behavior.

[Zygmunt Krynicki (zyga)]

Is this really doing something? AFAIK C *is* POSIX

review: Needs Information

[Daniel Manrique (roadmr)]

In my experiments C doesn't work and POSIX does (go ahead, give it a try, the bug has a 2-line repro case and since you have polish localization already installed you can just use that).

This despite my research indicating they are the same, as you say. http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap07.html

An alternative would be setting LANG=C.UTF-8 *and* LANGUAGE=en_US, that also worked, I just thought it was visually cleaner to set LANG to POSIX.UTF-8 only. But if you think it's semantically clearer the other way I'm fine with that.

=== modified file 'checkbox-old/checkbox/scripts/audio_settings.py'
--- checkbox-old/checkbox/scripts/audio_settings.py	2013-06-14 13:29:13 +0000
+++ checkbox-old/checkbox/scripts/audio_settings.py	2013-09-12 19:26:06 +0000
@@ -40,7 +40,7 @@
 entry_pattern = "Name: %s.*?(?=Properties)"
 
 
-def unlocalized_env(reset={"LANG": "C.UTF-8"}):
+def unlocalized_env(reset={"LANG": "POSIX.UTF-8"}):
     """
     Create un-localized environment.
 

=== modified file 'checkbox-old/debian/changelog'
--- checkbox-old/debian/changelog	2013-09-12 15:18:15 +0000
+++ checkbox-old/debian/changelog	2013-09-12 19:26:06 +0000
@@ -6,6 +6,8 @@
     (LP: #1206016)
   * Removed references to Ubuntu Friendly due to sunsetting of the project.
     (LP: #1224533)
+  * Ensured that pactl commands are run on a properly unlocalized environment
+    (LP: #1201126)
 
  -- Brendan Donegan <[e-mail]>  Mon, 09 Sep 2013 09:30:32 +0100