Merge lp:~roadmr/cdts/bluetooth-multichannel-audio into lp:cdts

Proposed by Daniel Manrique on 2014-01-24
Status: Merged
Approved by: Chris Gregan on 2014-01-24
Approved revision: 2349
Merged at revision: 2349
Proposed branch: lp:~roadmr/cdts/bluetooth-multichannel-audio
Merge into: lp:cdts
Diff against target: 85 lines (+65/-0)
2 files modified
plainbox-gui/jobs/multichannel-audio.txt.in (+17/-0)
plainbox-gui/whitelists/ihv-bluetooth.whitelist (+48/-0)
To merge this branch: bzr merge lp:~roadmr/cdts/bluetooth-multichannel-audio
Reviewer Review Type Date Requested Status
Sylvain Pineau Needs Information on 2014-01-28
Daniel Manrique Approve on 2014-01-24
Chris Gregan 2014-01-24 Pending
Review via email: mp+203134@code.launchpad.net

Commit message

Adding bluetooth whitelist, Better organization of files to be packaged in the provider, with specific jobs, whitelists and data directories, Addition of multichannel (dolby 5.1) test definition and data file.

Description of the change

- Adding bluetooth whitelist
- Better organization of files to be packaged in the provider, with specific jobs, whitelists and data directories
- Addition of multichannel (dolby 5.1) test definition and data file.

To post a comment you must log in.
Daniel Manrique (roadmr) wrote :

hm, I think tarmac will want an "approved" comment, so based on Chris's flipping of the status, I'll add such a comment.

review: Approve
Sylvain Pineau (sylvain-pineau) wrote :

Why did you add auto and non-auto version for those tests:

71 +suspend/bluetooth_obex_after_suspend
72 +suspend/bluetooth_obex_after_suspend_auto
73 +suspend/bluetooth_obex_browse_after_suspend
74 +suspend/bluetooth_obex_browse_after_suspend_auto
75 +suspend/bluetooth_obex_send_after_suspend
76 +suspend/bluetooth_obex_send_after_suspend_auto
77 +suspend/bluetooth_obex_get_after_suspend
78 +suspend/bluetooth_obex_get_after_suspend_auto

I thought that for ihv we had to avoid automatic tests.

review: Needs Information
Daniel Manrique (roadmr) wrote :

We can remove the auto ones if they're not desired. I probably put them there for completeness heh

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'plainbox-gui/data/dolby51.ac3'
2Binary files plainbox-gui/data/dolby51.ac3 1970-01-01 00:00:00 +0000 and plainbox-gui/data/dolby51.ac3 2014-01-24 17:38:55 +0000 differ
3=== added directory 'plainbox-gui/jobs'
4=== added file 'plainbox-gui/jobs/multichannel-audio.txt.in'
5--- plainbox-gui/jobs/multichannel-audio.txt.in 1970-01-01 00:00:00 +0000
6+++ plainbox-gui/jobs/multichannel-audio.txt.in 2014-01-24 17:38:55 +0000
7@@ -0,0 +1,17 @@
8+plugin: user-interact-verify
9+name: audio/dolby51
10+depends: audio/list_devices
11+estimated_duration: 120.0
12+requires:
13+ device.category == 'AUDIO'
14+command: totem $CHECKBOX_SHARE/audio/dolby51.ac3
15+_description:
16+ PURPOSE:
17+ Check that Dolby surround is working as expected using encoded mp4 with AC3 Passthrough.ate
18+ STEPS:
19+ 1. Click the test button
20+ 2. Open Edit menu and select Preferences
21+ 3. Click the Audio tab and set Audio Output Type to AC3 Passthrough.
22+ 4. Listen to the audio signal play across the various speakers in your setup
23+ VERIFICATION:
24+ Did the audio system perform as expected?
25
26=== added directory 'plainbox-gui/whitelists'
27=== renamed file 'plainbox-gui/data/ihv-audio.whitelist' => 'plainbox-gui/whitelists/ihv-audio.whitelist'
28=== added file 'plainbox-gui/whitelists/ihv-bluetooth.whitelist'
29--- plainbox-gui/whitelists/ihv-bluetooth.whitelist 1970-01-01 00:00:00 +0000
30+++ plainbox-gui/whitelists/ihv-bluetooth.whitelist 2014-01-24 17:38:55 +0000
31@@ -0,0 +1,48 @@
32+## This whitelist is intended to be run as part of IHV testing.
33+# A meta-job that includes the resources needed for a valid submission.
34+# Please do not remove without good reason.
35+miscellanea/submission-resources
36+#Info attachment jobs
37+__info__
38+codecs_attachment
39+cpuinfo_attachment
40+dmesg_attachment
41+dmi_attachment
42+dmidecode_attachment
43+efi_attachment
44+lspci_attachment
45+meminfo_attachment
46+modprobe_attachment
47+modules_attachment
48+sysctl_attachment
49+sysfs_attachment
50+udev_attachment
51+lsmod_attachment
52+acpi_sleep_attachment
53+installer_debug.gz
54+__bluetooth__
55+bluetooth/detect-output
56+bluetooth/browse-files
57+bluetooth/file-transfer
58+bluetooth/audio
59+bluetooth/audio-a2dp
60+bluetooth/HID
61+__suspend__
62+suspend/bluetooth_obex_before_suspend
63+suspend/bluetooth_obex_send_before_suspend
64+suspend/bluetooth_obex_browse_before_suspend
65+suspend/bluetooth_obex_get_before_suspend
66+suspend/bluetooth_obex_before_suspend_manual
67+suspend/suspend_advanced_auto
68+suspend/suspend_advanced
69+suspend/suspend-single-log-check
70+suspend/bluetooth_detect_after_suspend
71+suspend/bluetooth_obex_after_suspend
72+suspend/bluetooth_obex_after_suspend_auto
73+suspend/bluetooth_obex_browse_after_suspend
74+suspend/bluetooth_obex_browse_after_suspend_auto
75+suspend/bluetooth_obex_send_after_suspend
76+suspend/bluetooth_obex_send_after_suspend_auto
77+suspend/bluetooth_obex_get_after_suspend
78+suspend/bluetooth_obex_get_after_suspend_auto
79+suspend/bluetooth_obex_after_suspend_manual
80
81=== renamed file 'plainbox-gui/data/ihv-ethernet.whitelist' => 'plainbox-gui/whitelists/ihv-ethernet.whitelist'
82=== renamed file 'plainbox-gui/data/ihv-firmware.whitelist' => 'plainbox-gui/whitelists/ihv-firmware.whitelist'
83=== renamed file 'plainbox-gui/data/ihv-graphics.whitelist' => 'plainbox-gui/whitelists/ihv-graphics.whitelist'
84=== renamed file 'plainbox-gui/data/ihv-touch.whitelist' => 'plainbox-gui/whitelists/ihv-touch.whitelist'
85=== renamed file 'plainbox-gui/data/ihv-wireless.whitelist' => 'plainbox-gui/whitelists/ihv-wireless.whitelist'

Subscribers

People subscribed via source and target branches