Canonical SSO provider

Merge lp:~roadmr/canonical-identity-provider/verify-yes into lp:canonical-identity-provider/release

  1. verify-yes
  2. Merge into trunk
Proposed by Daniel Manrique
Status: Merged
Approved by: Daniel Manrique
Approved revision: no longer in the source branch.
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: lp:~roadmr/canonical-identity-provider/verify-yes
Merge into: lp:canonical-identity-provider/release
Diff against target: 12 lines (+1/-1)
1 file modified
src/webui/templates/account/emails.html (+1/-1)
To merge this branch: bzr merge lp:~roadmr/canonical-identity-provider/verify-yes
Reviewer Review Type Date Requested Status
Hasan Ammar (community) Approve
Review via email: mp+380850@code.launchpad.net

Commit message

Fix unclosed <a> tag that broke Verify email links

Description of the change

QA:

Before: no "verify" control on login/ubuntu.com/+emails unverified addresses

Before: YES "verify" control on login/ubuntu.com/+emails unverified addresses

To post a comment you must log in.
Revision history for this message
Hasan Ammar (hasanammar) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/webui/templates/account/emails.html'
2--- src/webui/templates/account/emails.html 2020-01-22 12:52:26 +0000
3+++ src/webui/templates/account/emails.html 2020-03-18 20:13:23 +0000
4@@ -64,7 +64,7 @@
5 <td class="email">{{ email }}</td>
6 {% if not readonly %}
7 <td class="u-align-text--right">
8- <a href="{% url_with_token 'verify_email' email_address=email.email %}" data-qa-id="verify_unverified_{{ email }}"{% trans "Verify" %}</a>
9+ <a href="{% url_with_token 'verify_email' email_address=email.email %}" data-qa-id="verify_unverified_{{ email }}">{% trans "Verify" %}</a>
10 {% if num_emails > 1 %}
11 <a href="{% url_with_token 'delete_email' email_address=email.email %}" data-qa-id="delete_unverified_{{ email }}">{% trans "Delete" %}</a>
12 {% endif %}