Merge lp:~roadmr/canonical-identity-provider/update-raven into lp:canonical-identity-provider/release

Proposed by Daniel Manrique on 2018-06-04
Status: Needs review
Proposed branch: lp:~roadmr/canonical-identity-provider/update-raven
Merge into: lp:canonical-identity-provider/release
Diff against target: 12 lines (+1/-1)
1 file modified
requirements.txt (+1/-1)
To merge this branch: bzr merge lp:~roadmr/canonical-identity-provider/update-raven
Reviewer Review Type Date Requested Status
Adam Collard (community) 2018-06-04 Approve on 2019-04-03
Review via email: mp+347402@code.launchpad.net

Commit message

Update raven to 6.9.0 for better Django 1.11-ness.

Basically gets rid of Django 2.0 deprecation warnings.

Description of the change

Update raven to 6.9.0 for better Django 1.11-ness.

Basically gets rid of Django 2.0 deprecation warnings.

To post a comment you must log in.
Adam Collard (adam-collard) wrote :

Is this still relevant?

Daniel Manrique (roadmr) wrote :

Yes; an SSO test run shows this:

/src/canonical-identity-provider/working/env/local/lib/python2.7/site-packages/raven/ contrib/django/client.py:150: RemovedInDjango20Warning: Using user.is_authenticated() and user.is_anonymous() as a method is deprecated. Remove the parentheses to use it as an attribute.
  authenticated = user.is_authenticated()

this MP would fix that warning.

review: Approve

Unmerged revisions

1640. By Daniel Manrique on 2018-06-04

Update raven to 6.9.0 for better Django 1.11-ness

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'requirements.txt'
2--- requirements.txt 2018-05-31 21:06:02 +0000
3+++ requirements.txt 2018-06-04 19:14:33 +0000
4@@ -30,7 +30,7 @@
5 pyasn1==0.1.9
6 pycparser==2.14
7 pymacaroons==0.9.1
8-raven==6.0.0
9+raven==6.9.0
10 requests==2.10.0
11 requests-oauthlib==0.4.2
12 six==1.10.0