Code review comment for lp:~roadmr/canonical-identity-provider/honor-authnrequest-nameid-policy-format-field

Revision history for this message
Daniel Manrique (roadmr) wrote :

Sure! Thanks!

I added a single check that verifies both because separating them left a test that would ERROR if the attribute is not there on a newly-created record, and I remember we always prefer tests that FAIL if expectations are not met in an expected way (i.e. not relying on an ERROR to stand for a FAIL).

« Back to merge proposal