Code review comment for lp:~roadmr/canonical-identity-provider/fix-email-oops

Celso Providelo (cprov) wrote :

Looks good if the admin code & testing are already unicode-friendly, unicode_literals is the way to go ...

The problem is not adopting it for the entire project in a timely manner, developers will get confused, for instance changes that work on admin.py will not work in models.py :-/

But let's go for it, since there is really no way back (think python 2.1!)

Minor comment inline about importing style.

review: Approve

« Back to merge proposal