Merge lp:~roadmr/canonical-identity-provider/fix-email-oops into lp:canonical-identity-provider/release
Status: | Merged |
---|---|
Approved by: | Daniel Manrique |
Approved revision: | no longer in the source branch. |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | lp:~roadmr/canonical-identity-provider/fix-email-oops |
Merge into: | lp:canonical-identity-provider/release |
Diff against target: |
44 lines (+15/-1) 2 files modified
src/identityprovider/admin.py (+1/-1) src/identityprovider/tests/test_admin.py (+14/-0) |
To merge this branch: | bzr merge lp:~roadmr/canonical-identity-provider/fix-email-oops |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Celso Providelo (community) | Approve | ||
Review via email: mp+347072@code.launchpad.net |
Commit message
Fix unicode error when building account links using displayname with non-ascii characters and format_html.
UnicodeEncodeError: 'ascii' codec can't encode characters in position 0-6: ordinal not in range(128)
File "django/
response = get_response(
File "django/
response = self._get_
File "django/
response = self.process_
File "django/
response = response.render()
File "django/
self.content = self.rendered_
File "django/
content = template.
File "django/
return self.template.
File "django/
return self._render(
File "django/
return self.nodelist.
File "django/
bit = node.render_
File "django/
return self.render(
File "django/
return compiled_
File "django/
return self.nodelist.
File "django/
bit = node.render_
File "django/
return self.render(
File "django/
return compiled_
File "django/
return self.nodelist.
File "django/
bit = node.render_
File "django/
return self.render(
File "django/
result = block.nodelist.
File "django/
bit = node.render_
File "django/
return self.render(
File "django/
result = block.nodelist.
File "django/
bit = node.render_
File "django/
return self.render(
File "django/
_dict = self.func(
File "django/
'results': list(results(cl))}
File "django/
yield ResultList(None, items_for_
File "django/
super(
File "django/
f, attr, value = lookup_
File "django/
value = attr(obj)
File "identityprovid
return build_account_
File "identityprovid
account.
File "django/
return mark_safe(
Description of the change
Fix unicode error when building account links using displayname with non-ascii characters and format_html.
Thanks, Daniel.
I cogitate unicode_literals for the entire file, but for the specific bugfix, I am think this specific/precise change is better.