Merge lp:~roadmr/canonical-identity-provider/fix-booboo into lp:canonical-identity-provider/release

Proposed by Daniel Manrique on 2018-05-28
Status: Merged
Approved by: Daniel Manrique on 2018-05-28
Approved revision: 1636
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: lp:~roadmr/canonical-identity-provider/fix-booboo
Merge into: lp:canonical-identity-provider/release
Diff against target: 14 lines (+2/-2)
1 file modified
src/identityprovider/widgets.py (+2/-2)
To merge this branch: bzr merge lp:~roadmr/canonical-identity-provider/fix-booboo
Reviewer Review Type Date Requested Status
Maximiliano Bertacchini 2018-05-28 Approve on 2018-05-28
Review via email: mp+346987@code.launchpad.net

Commit message

Fix bad invocation of format_html

Description of the change

Fix bad invocation of format_html

To post a comment you must log in.
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/identityprovider/widgets.py'
2--- src/identityprovider/widgets.py 2018-05-25 20:41:26 +0000
3+++ src/identityprovider/widgets.py 2018-05-28 17:10:30 +0000
4@@ -22,8 +22,8 @@
5
6 def account_to_lp_link(account):
7 if account and account.person:
8- link = format_html('<a href="https://launchpad.net/~%s">%s</a>' %
9- (account.person_name, account.person_name))
10+ link = format_html('<a href="https://launchpad.net/~{}">{}</a>',
11+ account.person_name, account.person_name)
12 else:
13 link = format_html('')
14 return link