~roadmr/canonical-identity-provider:better-username-errors

Branch merges

Propose for merging

Merged into canonical-identity-provider:master

Maximiliano Bertacchini: Approve on 2020-07-07

Hasan Ammar (community): Approve on 2020-07-07

Diff: 230 lines (+134/-11)

3 files modified

src/identityprovider/forms.py (+67/-11)
src/identityprovider/tests/test_forms.py (+58/-0)
src/webui/templates/registration/_create_account_form.html (+9/-0)

api

Superseded for merging into canonical-identity-provider:master

Ubuntu One hackers: Pending requested 2020-07-03

Diff: 231 lines (+123/-15)

4 files modified

src/identityprovider/forms.py (+65/-12)
src/identityprovider/tests/test_forms.py (+3/-1)
src/webui/templates/registration/_create_account_form.html (+18/-2)
src/webui/tests/test_views_registration.py (+37/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

c72a7fc... by Daniel Manrique on 2020-07-07

Review comments

058dd4d... by Daniel Manrique on 2020-07-06

Test changes for forms

99cfade... by Daniel Manrique on 2020-07-03

Express username validation with Django validators.

This allows much nicer, less generic error messages in the username
field which is very confusing for users.

9b3a6cc... by Daniel Manrique on 2020-07-03

Account creation form: Render all username validation errors with validation message formatting

67d722a... by Daniel Manrique on 2020-07-06

Visual tweaks to username format instructions.

* move instructions below the field
* fix css, nesting and styling
* simplify length instructions

Merged from https://code.launchpad.net/~roadmr/canonical-identity-provider/+git/canonical-identity-provider/+merge/386908

edf2dca... by Daniel Manrique on 2020-07-06

Visual tweaks to username format instructions.

* move instructions below the field
* fix css, nesting and styling
* simplify length instructions

3c85227... by Daniel Manrique on 2020-07-06

Explain the required username format in the registration form.

The intent is to explain to people what the format is BEFORE they try (and usually, fail) to get it right on the first try with no instructions.

If the form is submitted and the username has an error, we will no longer show the instructions because the error message should tell people what they did wrong so the instructions are redundant.

This can be enabled/disabled by USERNAME_SHOW_REQUIREMENTS feature flag, in case a lot of people counter-complain that it looks ugly/bad.

Merged from https://code.launchpad.net/~roadmr/canonical-identity-provider/+git/canonical-identity-provider/+merge/386845

7b17c61... by Daniel Manrique on 2020-07-06

periods at end of sentences.

0528063... by Daniel Manrique on 2020-07-03

template changes

942db33... by Daniel Manrique on 2020-07-03

Test registration view with username requirements