GMail Notifier

Merge lp:~rmyeid/gm-notify/setupFix into lp:gm-notify

  1. setupFix
  2. Merge into trunk
Proposed by Rami Al-Rfou'
Status: Merged
Merged at revision: not available
Proposed branch: lp:~rmyeid/gm-notify/setupFix
Merge into: lp:gm-notify
Diff against target: 26 lines (+3/-2)
2 files modified
gm-notify-config.py (+2/-1)
setup.py (+1/-1)
To merge this branch: bzr merge lp:~rmyeid/gm-notify/setupFix
Reviewer Review Type Date Requested Status
Alexander Hungenberg (community) Approve
Review via email: mp+22608@code.launchpad.net

Description of the change

Fixed the typos in the setup file and the bug in the configuration window.

To post a comment you must log in.
Revision history for this message
Alexander Hungenberg (alexander-hungenberg-gmail) wrote :

this looks good ;)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gm-notify-config.py'
2--- gm-notify-config.py 2010-03-31 21:04:32 +0000
3+++ gm-notify-config.py 2010-04-01 12:02:18 +0000
4@@ -91,7 +91,8 @@
5
6 # Sound
7 self.wTree.get_widget("checkbutton_sound").set_active(self.client.get_bool("/apps/gm-notify/play_sound"))
8- self.wTree.get_widget("fcbutton_sound").set_filename(self.client.get_string("/apps/gm-notify/soundfile"))
9+ if self.client.get_string("/apps/gm-notify/soundfile"):
10+ self.wTree.get_widget("fcbutton_sound").set_filename(self.client.get_string("/apps/gm-notify/soundfile"))
11 self.on_checkbutton_sound_toggled(self.wTree.get_widget("checkbutton_sound"))
12
13 # ClickAction
14
15=== modified file 'setup.py'
16--- setup.py 2010-03-31 21:04:32 +0000
17+++ setup.py 2010-04-01 12:02:18 +0000
18@@ -11,7 +11,7 @@
19 scripts=['gm-notify.py', 'gm-notify-config.py'],
20 data_files=[('/usr/share/applications', ['data/gm-notify.desktop']),
21 ('/usr/share/applications', ['data/gm-notify-config.desktop']),
22- ('/usr/share/indicators/messages/applications', ['data/gm-notify.py'])
23+ ('/usr/share/indicators/messages/applications', ['data/gm-notify.py']),
24 ('/usr/share/gm-notify', ['data/checking.gif']),
25 ('/usr/share/icons/hicolor/16x16/apps/', ['data/gm-notify.png']),
26 ('/usr/share/gm-notify', ['gm-config.glade']),

Subscribers

People subscribed via source and target branches

to status/vote changes: