snappy-hwe-snaps

Merge ~rmescandon/snappy-hwe-snaps/+git/engineering-tests:nm-debug-config-test into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

  1. Git
  2. lp:~rmescandon/snappy-hwe-snaps/+git/engineering-tests
  3. nm-debug-config-test
  4. Merge into master
Proposed by Roberto Mier Escandon
Status: Merged
Approved by: Konrad Zapałowicz
Approved revision: a09e2d8daa45515a753a98d9e2b0748b41c91bbd
Merged at revision: 7c2447984ea2d839a8d8515f8117edc9efaa1fb7
Proposed branch: ~rmescandon/snappy-hwe-snaps/+git/engineering-tests:nm-debug-config-test
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master
Diff against target: 62 lines (+54/-0)
1 file modified
com.canonical.se:engineering-tests/units/network-manager/network-manager.pxu (+54/-0)
Reviewer Review Type Date Requested Status
Konrad Zapałowicz (community) code Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+327102@code.launchpad.net

Description of the change

Plainbox tests for network manager debug enable/disable config option

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:76ec3c696c2058b3b41565f005f78dd09af924c5
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1758/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/2518/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1665/console
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/2036/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1758/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:e9756ff6c1e7ea9332c5f1a456f750806b31415d
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1760/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/2520
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1668/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/2820
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/2039/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1760/rebuild

review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:60201dd66c3329e87cf42f4c8a9f11bf28079d70
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1795/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/2596
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1703/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/2889
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/2108/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1795/rebuild

review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:fe7eda662bde3e5795738f5f8f59292ca122cd95
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1926/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/3278
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1834/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/3541
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/2740/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1926/rebuild

review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Continuous integration, rev:a09e2d8daa45515a753a98d9e2b0748b41c91bbd
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1927/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-build-snap-worker/3279
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/1835/console
    SUCCESS: https://jenkins.canonical.com/system-enablement/job/generic-test-snap/3542
    None: https://jenkins.canonical.com/system-enablement/job/generic-cleanup-snap/2741/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/1927/rebuild

review: Approve (continuous-integration)
Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

lgtm

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/com.canonical.se:engineering-tests/units/network-manager/network-manager.pxu b/com.canonical.se:engineering-tests/units/network-manager/network-manager.pxu
2index 27d9b8b..e905919 100644
3--- a/com.canonical.se:engineering-tests/units/network-manager/network-manager.pxu
4+++ b/com.canonical.se:engineering-tests/units/network-manager/network-manager.pxu
5@@ -323,3 +323,57 @@ _steps:
6 $ sudo apt install wakeonlan
7 _verification:
8 Did the SUT wake up from S5?
9+
10+id: network_manager/debug/default_off
11+category_id: network_manager
12+plugin: manual
13+_summary: The debug option defaults to off
14+_purpose:
15+ Makes sure that the debug option defaults to disabled
16+_steps:
17+ 1. Install the network-manager snap fresh (i.e. not an upgrade)
18+ 2. Run the following:
19+ .
20+ $ sudo snap get network-manager debug.enable
21+_verification:
22+ Verify that the returned value is "false"
23+
24+id: network_manager/debug/disabling_works
25+category_id: network_manager
26+plugin: manual
27+depends: network_manager/debug/default_off
28+_summary: Disabling debug actually disables debug logging
29+_purpose:
30+ Makes sure that when debug.enabled is set to "false" no debug logs are written
31+_steps:
32+ 1. Make sure that debug is disabled. Run:
33+ .
34+ $ sudo snap set network-manager debug.enable=false
35+ .
36+ 2. Show only most recent journal entries
37+ .
38+ $ sudo journalctl -f -u snap.network-manager.networkmanager.service
39+ .
40+_verification:
41+ Verify that any new log entry in journal coming from network-manager is in <info>,
42+ <warn> or <error>, but never in <debug> level
43+
44+id: network_manager/automount/debug_works
45+category_id: network_manager
46+plugin: manual
47+depends: network_manager/debug/default_off
48+_summary: When debug is enabled, debug logs are available
49+_purpose:
50+ Makes sure that when debug option is enabled the <debug> logs are available
51+_steps:
52+ 1. Make sure that debug is enabled. Run:
53+ .
54+ $ sudo snap set network-manager debug.enable=true
55+ .
56+ 2. Show only most recent journal entries
57+ .
58+ $ sudo journalctl -f -u snap.network-manager.networkmanager.service
59+ .
60+_verification:
61+ Verify that any new log entry in journal coming from network-manager is in <debug>
62+ level

Subscribers

People subscribed via source and target branches