Merge lp:~rmescandon/jenkins-launchpad-plugin/prevent-exception-when-no-downstream-project into lp:jenkins-launchpad-plugin

[Roberto Mier Escandon]

I've hit exceptions when using launchpadTrigger with a job that hasn't downstream projects

[Joshua Powers (powersj)]

Looks like you and I both have run into this:

https://code.launchpad.net/~powersj/jenkins-launchpad-plugin/add-jenkins-pipeline-support/+merge/326245

You can either comment on mine or what we can do is if you fix your bare except (e.g. except -> except KeyError) and add a log message and then I can accept yours.

review: Needs Fixing

Unmerged revisions

133. By Roberto Mier Escandon on 2017-11-13

prevent exception when not set downstreamProjects job data

=== modified file 'jlp/jenkinsutils.py'
--- jlp/jenkinsutils.py	2016-08-13 01:08:59 +0000
+++ jlp/jenkinsutils.py	2017-11-13 16:47:58 +0000
@@ -571,8 +571,11 @@
 def get_downstream_projects(jenkins, job_url):
     data = jenkins.get_json_data(job_url + '/')
     downstream_projects = []
-    for project in data['downstreamProjects']:
-        downstream_projects.append(project['name'])
+    try:
+        for project in data['downstreamProjects']:
+            downstream_projects.append(project['name'])
+    except:
+        pass
     return downstream_projects