Merge lp:~rlane/nova/lp681164 into lp:~hudson-openstack/nova/trunk
Proposed by
Ryan Lane
Status: | Merged |
---|---|
Approved by: | Todd Willey |
Approved revision: | 394 |
Merged at revision: | 548 |
Proposed branch: | lp:~rlane/nova/lp681164 |
Merge into: | lp:~hudson-openstack/nova/trunk |
Diff against target: |
177 lines (+53/-38) 1 file modified
nova/auth/ldapdriver.py (+53/-38) |
To merge this branch: | bzr merge lp:~rlane/nova/lp681164 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Todd Willey (community) | Approve | ||
Vish Ishaya (community) | Approve | ||
Review via email: mp+44930@code.launchpad.net |
Description of the change
Changing DN creation to do searches for entries.
This change adds additional interoperability (as many directory servers and LDAP admins use cn, or another attribute, as the naming attribute). DN creation will incur a slight performance penalty for doing so, as DNs must be searched for now. User and project creation skip this performance penalty, as there is no need to search for an entry that is being created.
To post a comment you must log in.
lgtm.
Ryan, you might want to do a bzr whoami "Ryan Lane <valid email>" at some point so your commits actually have the right email address and are linked to your bzr account.