Merge lp:~rlaager/ecryptfs/fix-lp-1574174-2 into lp:ecryptfs
Proposed by
Richard Laager
Status: | Merged |
---|---|
Merged at revision: | 881 |
Proposed branch: | lp:~rlaager/ecryptfs/fix-lp-1574174-2 |
Merge into: | lp:ecryptfs |
Diff against target: |
12 lines (+1/-1) 1 file modified
src/utils/ecryptfs-setup-private (+1/-1) |
To merge this branch: | bzr merge lp:~rlaager/ecryptfs/fix-lp-1574174-2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tyler Hicks | Approve | ||
Review via email: mp+292866@code.launchpad.net |
This proposal supersedes a proposal from 2016-04-25.
Description of the change
Fix improper "already mounted" errors with ZFS
The obvious approach for using ZFS and ecryptfs together involves
creating a dataset like this:
zfs create -o mountpoint=
As a result, /proc/mounts looks like this:
rpool/home/USER /home/.
ecryptfs-
which was effectively left-anchored. Unfortunately, this can match the
device column. A space at the beginning of the pattern corrects this.
To post a comment you must log in.
Hi Richard - Thanks for the merge proposal. I could be wrong because I didn't test this but I think adding a leading space to CRYPTDIR would break the "already mounted" check since CRYPTDIR is the device (or source) and will be listed at the beginning of a line in /proc/mounts. The check will never fail even if the CRYPTDIR is already mounted.