Merge ~rjschwei/cloud-init:sysvinitSUSE into cloud-init:master
Proposed by
Robert Schweikert
on 2017-09-21
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 243ec59fb62a8710430f9ba1e2490ee964c1abc0 | ||||
| Proposed branch: | ~rjschwei/cloud-init:sysvinitSUSE | ||||
| Merge into: | cloud-init:master | ||||
| Diff against target: |
497 lines (+455/-0) 5 files modified
setup.py (+2/-0) sysvinit/suse/cloud-config (+113/-0) sysvinit/suse/cloud-final (+113/-0) sysvinit/suse/cloud-init (+114/-0) sysvinit/suse/cloud-init-local (+113/-0) |
||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Scott Moser | 2017-09-21 | Needs Fixing on 2017-09-21 | |
|
Review via email:
|
|||
Description of the Change
Integrate sys-v-init support for SUSE LP#1718649
To post a comment you must log in.
~rjschwei/cloud-init:sysvinitSUSE
updated
on 2017-09-21
- cd6cc9b... by Robert Schweikert on 2017-09-21
| Robert Schweikert (rjschwei) wrote : | # |
OK, fixed with cd6cc9b


this looks fine, but i'd like to drop the extended GPL header content either entirely (the systemd and upstart units do not have any license info) or at least replace it with the simple:
# This file is part of cloud-init. See LICENSE file for license information.
if you want i'm willing to keep Author and Copyright in place:
# Copyright (C) 2012 Yahoo! Inc.
# Copyright (C) 2013 SUSE LLC
#
# Author: Joshua Harlow <email address hidden>
# Author: Robert Schweikert <email address hidden>
#
# This file is part of cloud-init. See LICENSE file for license information.
But I'd prefer the first option.