Code review comment for lp:~ris/unity-2d/fix-692444

Revision history for this message
Robert Sajdok (ris) wrote :

> I confirm this previous statement: it fails because the window name is
> translated. But that's not the only reason, a pointer to a QString is created
> and is then passed to QString::compare which should fail:
>
> 54 + QString *windowName = new QString(wnck_window_get_name(wnckWindow));
> 55 +
> 56 + int found = QString::compare("Trash", windowName,
> Qt::CaseSensitive);
>
>
> The following should work better:
>
> QString windowName = QString(wnck_window_get_name(wnckWindow);

Try this version it should work fine.

« Back to merge proposal